From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-110381-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 862 invoked by alias); 13 Feb 2014 19:42:00 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 852 invoked by uid 89); 13 Feb 2014 19:42:00 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: glazunov.sibelius.xs4all.nl
Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 13 Feb 2014 19:41:58 +0000
Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1])	by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id s1DJfoTK011108;	Thu, 13 Feb 2014 20:41:50 +0100 (CET)
Received: (from kettenis@localhost)	by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id s1DJfn5n018925;	Thu, 13 Feb 2014 20:41:49 +0100 (CET)
Date: Thu, 13 Feb 2014 19:42:00 -0000
Message-Id: <201402131941.s1DJfn5n018925@glazunov.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: jose.marchesi@oracle.com
CC: gdb-patches@sourceware.org
In-reply-to: <874n439dgk.fsf@oracle.com> (jose.marchesi@oracle.com)
Subject: Re: [PATCH][SPARC64] Fix invalid offsets to access fpregset_t
References:  <874n439dgk.fsf@oracle.com>
X-SW-Source: 2014-02/txt/msg00480.txt.bz2

> 
> Hi.
> 
> I noticed that the %fsr register is not being properly accessed from gdb
> in sparc64.  This is because sparc64_supply_fpregset and
> sparc64_collect_fpregset are using the offsets from the
> sparc32_bsd_fpregset constant instead of sparc64_bsd_fpregset.
> 
> How to reproduce the problem: set %f32 to some value and see how $fsr is
> modified as well.  Also, execute a FCMP* instruction (if (myfloat >
> 3.14)) and see how $fsr does not change to reflect the fp condition
> codes.
> 
> I checked and the BSD sparc64 targets are using the proper offsets.
> Ditto for the linux sparc32 target.
> 
> This little patch fixes this problem.  No noticeable regressions running
> the test suite.
> 
> Ok to apply?

Sure!

> 2014-02-13  Jose E. Marchesi  <jose.marchesi@oracle.com>
> 
> 	* sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Register
> 	the proper offsets to access fpregset_t.
>