From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31401 invoked by alias); 12 Feb 2014 03:32:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31391 invoked by uid 89); 12 Feb 2014 03:32:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 12 Feb 2014 03:32:36 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 8EEE5116594; Tue, 11 Feb 2014 22:32:34 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id HH5mlXjgMpzY; Tue, 11 Feb 2014 22:32:34 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 05B31116346; Tue, 11 Feb 2014 22:32:33 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id E44D2E05F6; Wed, 12 Feb 2014 07:32:34 +0400 (RET) Date: Wed, 12 Feb 2014 03:32:00 -0000 From: Joel Brobecker To: Mark Kettenis Cc: sanimir.agovic@intel.com, gdb-patches@sourceware.org Subject: Re: [PATCH] cleanup: remove declared variables without any references Message-ID: <20140212033234.GQ5485@adacore.com> References: <1392126951-25347-1-git-send-email-sanimir.agovic@intel.com> <201402111412.s1BECWEX000161@glazunov.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201402111412.s1BECWEX000161@glazunov.sibelius.xs4all.nl> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-02/txt/msg00379.txt.bz2 Hello Sanimir, Thanks for sending the patches! As you can see, bunching the changes together is causing a little extra work, now, because multiple reviews end up being involved, and we end up having to keep track of what was already reviewed, and what has not. I know it's a lot of files, but all these changes should be mostly independent, so we could go one file at a time, a few files each day. When we've finished reviewing the a batch, just send another. WDYT? > > The mipsnbsd-tdep.c one is not ok. For one thing, you're leaving > behind the comment describing the code. But I think this is better > left alone, as somebody might want to add (or put back) the missing > glue that uses those bits. Hey Mark! The problem with leaving them behind is that they cause a build failure when building the HEAD, I think, because we build with -Werror. Can we find a way to avoid that? For instance, could we #if zero the code? > > 2014-02-11 Sanimir Agovic > > > > * cris-tdep.c (cris_supply_gregset): Remove zerobuf. > > (_initialize_cris_tdep): Remove cris_set_cmdlist, cris_show_cmdlist. > > * h8300-tdep.c (setmachinelist): Remove global. > > * hppa-tdep.c (hppa_sigtramp): Remove global. > > * ia64-tdep.c (fp_regnum, lr_regnum): Remove globals. > > * mipsnbsd-tdep.c (sigtramp_retcode_mipsel, sigtramp_retcode_mipseb): > > Remove globals. > > * ravenscar-thread.c (update_target_observer): Remove global. > > * rs6000-tdep.c (rs6000_gdbarch_init): Remove segment_regs. > > * symfile-debug.c (debug_sym_fns): Remove global. The h8300-tdep.c, ravenscar-thread.c changes are OK. the ia64-tdep.c is officially Jan's jurisdiction, but the change looks OK to me. If he doesn't object by, say, end of this week, please apply the change (Jan: I'll revert immediately if you object). The rs6000-tdep.c change is OK. It looks like it was already unused when it was introduced, and I think it was an unintentional left over from the development phase where the table was first defined at one location, and then later moved to a different location (init_sim_regno_table). See commit: commit 7cc46491b1832408d1d5472e3f0c17c8a1d78ccb Date: Mon Oct 15 19:45:31 2007 +0000 This leaves symfile-debug.c, for which I don't know. -- Joel