From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10478 invoked by alias); 11 Feb 2014 16:38:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10427 invoked by uid 89); 11 Feb 2014 16:38:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Feb 2014 16:38:23 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1BGcLS0022822 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 11 Feb 2014 11:38:21 -0500 Received: from localhost.localdomain (ovpn-113-31.phx2.redhat.com [10.3.113.31]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s1BGcKxk018166 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Tue, 11 Feb 2014 11:38:21 -0500 Date: Tue, 11 Feb 2014 16:38:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Pedro Alves Subject: Re: [RFC] rl78: vtables are code addresses Message-ID: <20140211093820.23de6ad4@redhat.com> In-Reply-To: <52F9FE9D.6050603@redhat.com> References: <20140210234449.27faedc6@redhat.com> <52F9FE9D.6050603@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg00357.txt.bz2 On Tue, 11 Feb 2014 10:42:37 +0000 Pedro Alves wrote: > Thus, wouldn't it be a little better to mark the baked in struct > type as code to begin with? > > --- > gdb/gnu-v3-abi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/gnu-v3-abi.c b/gdb/gnu-v3-abi.c > index a08dc36..ceccbe5 100644 > --- a/gdb/gnu-v3-abi.c > +++ b/gdb/gnu-v3-abi.c > @@ -171,7 +171,7 @@ build_gdb_vtable_type (struct gdbarch *arch) > TYPE_TAG_NAME (t) = "gdb_gnu_v3_abi_vtable"; > INIT_CPLUS_SPECIFIC (t); > > - return t; > + return make_type_with_address_space (t, TYPE_INSTANCE_FLAG_CODE_SPACE); > } > > > I believe this makes no difference for archs with flat address space. > (testing on x86-64 GNU/Linux shows no changes). Very nice. I've tested your patch and find that it produces results identical to what I was getting with my patch. Please check it in... (Or, if you'd prefer that I check it in, please let me know.) Thanks! Kevin