From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27292 invoked by alias); 11 Feb 2014 04:45:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27283 invoked by uid 89); 11 Feb 2014 04:45:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 11 Feb 2014 04:45:32 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 7D917116449; Mon, 10 Feb 2014 23:45:30 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 6B-+ZHMB6BrJ; Mon, 10 Feb 2014 23:45:30 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 24941116434; Mon, 10 Feb 2014 23:45:30 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id A1291E042B; Tue, 11 Feb 2014 08:45:30 +0400 (RET) Date: Tue, 11 Feb 2014 04:45:00 -0000 From: Joel Brobecker To: "Jose E. Marchesi" Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix passing double float complex arguments in sparc64 Message-ID: <20140211044530.GJ5485@adacore.com> References: <87d2jid9kk.fsf@oracle.com> <87mwi5s7me.fsf@oracle.com> <20140208024729.GJ5485@adacore.com> <87bnyfgkw4.fsf@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87bnyfgkw4.fsf@oracle.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-02/txt/msg00336.txt.bz2 > Somehow I missed the fact that for big structs and unions the writing of > the "additional" register is performed immediately after setting regnum. > A bit confusing, but that avoids repeated logic in the `if (regnum != > 1)' block, so I agree it is a better solution. Thank you. I don't think one way is all that better than the other (I actually find this way a little confusing at first), but I prefer that everything remains consistent... > n2013-10-15 Jose E. Marchesi > > * sparc64-tdep.c (sparc64_store_arguments): Do not align complex > double float arguments to 16-byte in the argument slots. The patch is OK. Watch out for the 'n' at the start of the date in this ChangeLog entry. Just one tiny formatting request before committing: > + /* Float Complex or double Complex arguments. */ > + if (element < 16) > + { > + regnum = SPARC64_D0_REGNUM + element; > + > + if (len == 16) Can you remove the tabs/spaces in the empty line before the "if"? Thank you, -- Joel