From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15778 invoked by alias); 10 Feb 2014 14:23:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15764 invoked by uid 89); 10 Feb 2014 14:23:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 10 Feb 2014 14:23:24 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3C6041163E6; Mon, 10 Feb 2014 09:23:22 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 3KjzwYEmvRv4; Mon, 10 Feb 2014 09:23:22 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id CE0D61163E1; Mon, 10 Feb 2014 09:23:21 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 12AF1E075B; Mon, 10 Feb 2014 18:23:22 +0400 (RET) Date: Mon, 10 Feb 2014 14:23:00 -0000 From: Joel Brobecker To: Mark Kettenis Cc: xdje42@gmail.com, gdb-patches@sourceware.org Subject: Re: [PATCH] Makefile fix Message-ID: <20140210142322.GX5485@adacore.com> References: <201402041033.s14AX8Ai013211@glazunov.sibelius.xs4all.nl> <201402081141.s18Bf6U4019336@glazunov.sibelius.xs4all.nl> <201402101315.s1ADFO19018000@glazunov.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201402101315.s1ADFO19018000@glazunov.sibelius.xs4all.nl> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-02/txt/msg00301.txt.bz2 > The problem here as having two targets with exactly the same rule. > Easiest way to fix this is to simply drop $(LIBGNU) as target and have only: > > $(GNULIB_H): $(GNULIB_BUILDDIR)/Makefile > @$(MAKE) $(FLAGS_TO_PASS) DO=all DODIRS=$(GNULIB_BUILDDIR) subdir_do > > I don't think that will break anything. But then I thought the same > about the previous diff... I am wondering if we could handle gnulib more or less the same way we handle libiberty or libbfd, ie depend on $(LIBGNU)? The difference, in the case of libgnu, is that we are configuring gnulib from GDB as opposed to from the root directory. If necessary, perhaps now is the time to move gnulib to the root directory as we've been talking about a few times before? -- Joel