From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2401 invoked by alias); 9 Feb 2014 17:08:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2390 invoked by uid 89); 9 Feb 2014 17:08:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-lb0-f179.google.com Received: from mail-lb0-f179.google.com (HELO mail-lb0-f179.google.com) (209.85.217.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sun, 09 Feb 2014 17:08:29 +0000 Received: by mail-lb0-f179.google.com with SMTP id l4so4024379lbv.24 for ; Sun, 09 Feb 2014 09:08:26 -0800 (PST) X-Received: by 10.152.236.72 with SMTP id us8mr18614724lac.11.1391965706187; Sun, 09 Feb 2014 09:08:26 -0800 (PST) Received: from home.pavel.comp (paulfertser.info. [2001:470:26:54b:250:70ff:fee7:41ec]) by mx.google.com with ESMTPSA id w2sm17906467lad.4.2014.02.09.09.08.24 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Sun, 09 Feb 2014 09:08:25 -0800 (PST) Received: (from pavel@localhost) by home.pavel.comp (8.14.5/8.13.8) id s19H8MKE011005; Sun, 9 Feb 2014 21:08:22 +0400 Date: Sun, 09 Feb 2014 17:08:00 -0000 From: Paul Fertser To: Jan Kratochvil Cc: Eli Zaretskii , gdb-patches@sourceware.org, ktietz@redhat.com Subject: Re: [PATCH] Add IPv6 support for remote TCP connections Message-ID: <20140209170821.GI2320@home.lan> References: <1391878435-19340-1-git-send-email-fercerpav@gmail.com> <20140209083056.GA32481@host2.jankratochvil.net> <20140209095308.GH2320@home.lan> <20140209130501.GA15183@host2.jankratochvil.net> <83k3d4utwr.fsf@gnu.org> <20140209164748.GA25629@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140209164748.GA25629@host2.jankratochvil.net> User-Agent: Mutt/1.5.17 (2007-11-30) X-SW-Source: 2014-02/txt/msg00260.txt.bz2 On Sun, Feb 09, 2014 at 05:47:48PM +0100, Jan Kratochvil wrote: > On Sun, 09 Feb 2014 17:34:28 +0100, Eli Zaretskii wrote: > > Did you include ws2tcpip.h? That's the header where getaddrinfo and > > all that is needed to use it are declared, per the MSDN documentation: > > > > http://msdn.microsoft.com/en-us/library/windows/desktop/ms738520%28v=vs.85%29.aspx > > The patch with really builds OK on Fedora mingw64. I'm testing exactly that right atm and came to the same conclusion. > I did not expect the function may be missing just due to a non-standard header > file. But gnulib docs say "This function is missing on some platforms: HP-UX 11.11, IRIX 6.5, OSF/1 5.1, Solaris 7, Cygwin 1.5.x, mingw, MSVC 9, Interix 3.5, BeOS", is it really ok this way? > OK, we can now go with the patch and merge in gdbserver bits from my patch. I tested my patch against OpenOCD locally and it seems to behave as expected, but I admit that's not a really thorough testing. Another point: configure.ac should probably check for getaddrinfo in "nsl" and "socket" as Solaris docs say both libs are required for it. Regarding gdbserver mods, I didn't test it at all but from a cursory look at the source code it feels like the user can't specify if an ipv4 or ipv6 socket should be used? And that only a single socket is bound, so if ipv6 is available, it'll bind to ipv6 and if the particular system doesn't map ipv4 address space to ipv6 (such as OpenBSD) then it wouldn't be possible to make gdbserver accessible on legacy ipv4 at all? Sorry if I'm missing something obvious here, just wanted to make sure it's all covered. Do you want me to send any updates to this patch or will you handle it yourself now? -- Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software! mailto:fercerpav@gmail.com