From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20406 invoked by alias); 9 Feb 2014 03:49:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20395 invoked by uid 89); 9 Feb 2014 03:49:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Sun, 09 Feb 2014 03:49:48 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id B882E11625F; Sat, 8 Feb 2014 22:49:46 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id mJFzdCIExsqe; Sat, 8 Feb 2014 22:49:46 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 4AF9911625E; Sat, 8 Feb 2014 22:49:46 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 89A9AE0BFC; Sun, 9 Feb 2014 07:49:45 +0400 (RET) Date: Sun, 09 Feb 2014 03:49:00 -0000 From: Joel Brobecker To: Sanimir Agovic Cc: tromey@redhat.com, keven.boell@intel.com, gdb-patches@sourceware.org Subject: Re: [PATCH v5 00/15] C99 variable length array support Message-ID: <20140209034945.GO5485@adacore.com> References: <1391704056-25246-1-git-send-email-sanimir.agovic@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1391704056-25246-1-git-send-email-sanimir.agovic@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-02/txt/msg00251.txt.bz2 > this patch series (v5) add C99 variable length support to gdb. Thanks for sending the latest version of the patch series. The log of the changes between each series is also very helpful. I scanned through each patch, and have no real new comment. FOAD, this is unfortunately not an approval, since I don't feel comfortable enough with dwarf2read to review them well. The next step for me is to test those changes against the AdaCore testsuite. I will try to schedule that early next week. -- Joel