From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26077 invoked by alias); 7 Feb 2014 10:27:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26063 invoked by uid 89); 7 Feb 2014 10:27:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 07 Feb 2014 10:27:19 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 55C5711666F; Fri, 7 Feb 2014 05:27:17 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id XAKeG-uwFF1m; Fri, 7 Feb 2014 05:27:17 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id DE52D1164FA; Fri, 7 Feb 2014 05:27:16 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 3FA7EE0BA8; Fri, 7 Feb 2014 14:27:15 +0400 (RET) Date: Fri, 07 Feb 2014 10:27:00 -0000 From: Joel Brobecker To: Sanimir Agovic Cc: tromey@redhat.com, keven.boell@intel.com, gdb-patches@sourceware.org Subject: Re: [PATCH v5 09/15] vla: resolve dynamic bounds if value contents is a constant byte-sequence Message-ID: <20140207102715.GF5485@adacore.com> References: <1391704056-25246-1-git-send-email-sanimir.agovic@intel.com> <1391704056-25246-10-git-send-email-sanimir.agovic@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1391704056-25246-10-git-send-email-sanimir.agovic@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-02/txt/msg00191.txt.bz2 Hello! > 2013-11-26 Sanimir Agovic > Keven Boell > > * findvar.c (default_read_var_value): Resolve dynamic bounds if location > points to a constant blob. Small trivial comment.... > case LOC_CONST_BYTES: > + if (is_dynamic_type (type)) > + /* Value is a constant byte-sequence and needs no memory access. */ > + type = resolve_dynamic_type (type, /* Unused address. */ 0); Although not required by C, we prefer in the GDB project to still use curly braces around the if block. The reason is that the comment visually looks like a statement, so it looks like the if block as more than one statement, hence the use of curly braces... Thank you! -- Joel