From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21615 invoked by alias); 5 Feb 2014 12:37:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21605 invoked by uid 89); 5 Feb 2014 12:37:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: glazunov.sibelius.xs4all.nl Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 05 Feb 2014 12:37:48 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id s15CbhK5029267; Wed, 5 Feb 2014 13:37:43 +0100 (CET) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id s15CbhlK028161; Wed, 5 Feb 2014 13:37:43 +0100 (CET) Date: Wed, 05 Feb 2014 12:37:00 -0000 Message-Id: <201402051237.s15CbhlK028161@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: brobecker@adacore.com CC: gdb-patches@sourceware.org In-reply-to: <20140205021312.GB5485@adacore.com> (message from Joel Brobecker on Wed, 5 Feb 2014 06:13:12 +0400) Subject: Re: [PATCH] Fix building with yacc References: <201402031351.s13DpgDY020084@glazunov.sibelius.xs4all.nl> <20140205021312.GB5485@adacore.com> X-SW-Source: 2014-02/txt/msg00037.txt.bz2 > Date: Wed, 5 Feb 2014 06:13:12 +0400 > From: Joel Brobecker > > Hi Mark, > > > OpenBSD yacc doesn't use YYPRINT, so we end up with gcc complaining > > that c_print_token is defined but not used. As far as I can determine > > YYPRINT is a bison-ism, so the diff below wraps c_print_token in > > #ifdef YYBISON. > > > > ok? > > I don't know bison much to really review the patch, but I think > that you meant c_print_token to remain static, right? (see below) > Aside from that, the change looks OK to me. Oops. Thanks for spotting that. Below is what I ended up committing: >From 12c5175d68a840960e4cf7d3001c926f15c4d006 Mon Sep 17 00:00:00 2001 From: Mark Kettenis Date: Wed, 5 Feb 2014 13:30:33 +0100 Subject: [PATCH] Avoid bison-isms when using yacc. YYPRINT is a bison-ism so c_print_token() ends up being unused when yacc is used which makes gcc unhappy. Make sure we only define YYPRINT and c_print_token() when bison is used to generate the parser. gdb/ChangeLog: * c-exp.y (YYPRINT, c_print_token): Only define if YYBISON is defined. --- gdb/ChangeLog | 5 +++++ gdb/c-exp.y | 6 ++++++ 2 files changed, 11 insertions(+) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index a6fa6fc..fcec355 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2014-02-05 Mark Kettenis + + * c-exp.y (YYPRINT, c_print_token): Only define if YYBISON is + defined. + 2014-02-05 Yao Qi * remote.c (remote_pass_signals): Remove local 'buf' and use diff --git a/gdb/c-exp.y b/gdb/c-exp.y index 277242e..4704845 100644 --- a/gdb/c-exp.y +++ b/gdb/c-exp.y @@ -169,8 +169,10 @@ static struct stoken operator_stoken (const char *); static void check_parameter_typelist (VEC (type_ptr) *); static void write_destructor_name (struct stoken); +#ifdef YYBISON static void c_print_token (FILE *file, int type, YYSTYPE value); #define YYPRINT(FILE, TYPE, VALUE) c_print_token (FILE, TYPE, VALUE) +#endif %} %type exp exp1 type_exp start variable qualified_name lcurly @@ -3201,6 +3203,8 @@ c_parse (void) return result; } +#ifdef YYBISON + /* This is called via the YYPRINT macro when parser debugging is enabled. It prints a token's value. */ @@ -3255,6 +3259,8 @@ c_print_token (FILE *file, int type, YYSTYPE value) } } +#endif + void yyerror (char *msg) { -- 1.8.5.3