From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25695 invoked by alias); 22 Jan 2014 04:52:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25679 invoked by uid 89); 22 Jan 2014 04:52:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: mx.tkos.co.il Received: from guitar.tcltek.co.il (HELO mx.tkos.co.il) (192.115.133.116) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 22 Jan 2014 04:52:06 +0000 Received: from tarshish (unknown [10.0.8.6]) by mx.tkos.co.il (Postfix) with ESMTPSA id 16BD64405F4; Wed, 22 Jan 2014 06:52:04 +0200 (IST) Date: Wed, 22 Jan 2014 04:52:00 -0000 From: Baruch Siach To: Pedro Alves Cc: gdb-patches@sourceware.org, Maxim Grigoriev , Marc Gauthier , Dror Maydan , Woody LaRue , Chris Zankel Subject: Re: [PATCH v2] gdb: xtensa: fix linux ptrace includes Message-ID: <20140122045202.GM12751@tarshish> References: <52DD0D6C.1040309@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52DD0D6C.1040309@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00837.txt.bz2 Hi Pedro, On Mon, Jan 20, 2014 at 11:50:04AM +0000, Pedro Alves wrote: > On 01/19/2014 07:53 AM, Baruch Siach wrote: > > Currently, xtensa code using the Linux ptrace interface only include > > sys/ptrace.h. This file comes from the C library (glibc and uClibc, at least), > > and includes a declaration of the ptrace() functions, along with some cross > > architecture constants that are mostly copied from the file located at > > include/uapi/linux/ptrace.h in recent Linux kernels. > > > > For xtensa specific constants like PTRACE_GETXTREGS and PTRACE_SETXTREGS the > > asm/ptrace.h include from the Linux kernel UAPI is needed. The code in > > gdbserver xtensa specific part doesn't call ptrace() directly, so we can > > remove the unneeded sys/ptrace.h include. The gdb xtensa specific code needs > > both headers, since it calls ptrace(). > > Pushed, thanks. It would be nice to have this and the other xtensa fix in the 7.6 and 7.7 branches as well. Thanks, baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -