From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3166 invoked by alias); 16 Jan 2014 05:37:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3153 invoked by uid 89); 16 Jan 2014 05:37:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 16 Jan 2014 05:37:07 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 703951165BE; Thu, 16 Jan 2014 00:37:05 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id dF3E272GvTo1; Thu, 16 Jan 2014 00:37:05 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 014B5116517; Thu, 16 Jan 2014 00:37:04 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 580DFE013C; Thu, 16 Jan 2014 09:37:02 +0400 (RET) Date: Thu, 16 Jan 2014 05:37:00 -0000 From: Joel Brobecker To: Sergio Durigan Junior Cc: Michael Eager , gdb-patches ml , Keith Seitz Subject: Re: [PATCH] Regression setting breakpoint Message-ID: <20140116053702.GR4762@adacore.com> References: <52A8CD31.5090809@eagerm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-01/txt/msg00585.txt.bz2 > Not really a code review, but the ChangeLog entries should be of the > form: > > 2014-01-16 Your Name > > * file.c (function): What changed. FWIW, I have been using: | gdb/ChangeLog: | | * file.c (function): What changed. | | gdb/testsuite/ChangeLog: | | * gdb.base/file.exp: Bla bla bla. Two reasons: It makes it obvious which ChangeLog the entries refer to, and it avoids the need to put a date in the revision log, which may become obe due to the time it takes to get the patch in after it is written. The format with dates are accepted as well, of course. And I have seen people add the directory usually on the line just ahead of the CL entry. Eg: | gdb/: | 2014-01-16 Your Name -- Joel