From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4742 invoked by alias); 15 Jan 2014 18:07:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4724 invoked by uid 89); 15 Jan 2014 18:07:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 15 Jan 2014 18:07:37 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0FI7WmJ000801 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 15 Jan 2014 13:07:32 -0500 Received: from blade.nx (ovpn-116-91.ams2.redhat.com [10.36.116.91]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0FI7VPv017894; Wed, 15 Jan 2014 13:07:31 -0500 Received: by blade.nx (Postfix, from userid 1000) id 72FA2264357; Wed, 15 Jan 2014 18:07:30 +0000 (GMT) Date: Wed, 15 Jan 2014 18:07:00 -0000 From: Gary Benson To: Eli Zaretskii Cc: Joel Brobecker , binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: small request regarding commits in binutils-gdb.git Message-ID: <20140115180730.GA10264@blade.nx> References: <20140115121251.GM4639@adacore.com> <83mwix44gh.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83mwix44gh.fsf@gnu.org> X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00536.txt.bz2 Eli Zaretskii wrote: > > Date: Wed, 15 Jan 2014 16:12:51 +0400 > > From: Joel Brobecker > > > > It would look like this: > > > > > psymtab cleanup patch 3/3 > > > > > > This last patch removes "partial" from the names of > > > expand_partial_symbol_names and map_partial_symbol_filenames. > > > It also renames expand_partial_symbol_names to match the > > > struct quick_symbol_functions "method" that it wraps: > > > expand_symtabs_matching. > > > > > > This patch also adds two parameters to expand_symtabs_matching > > > so that it can fully wrap the underlying quick_symbol_functions method. > > > This makes it usable in more places. > > > I thought of having a cover function that still had the same > > > signature as the old expand_partial_symbol_names function, > > > but I couldn't think of a good name, and it wasn't clear it was > > > worth it anyway. > > > > > > gdb/ChangeLog: > > > > > > * symfile.h (expand_symtabs_matching): Renamed from > > > expand_partial_symbol_names. Update prototype. > > > (map_symbol_filenames): Renamed from map_partial_symbol_filenames. > > > * symfile.c (expand_symtabs_matching): Renamed from > > The text before the log entry is just a long way of saying the same > thing as the log entry, isn't it? It repeats the info that is > already in the log entry. Why does it make sense to repeat all > that? The ChangeLog says what. The text before it says why. Cheers, Gary -- http://gbenson.net/