From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26344 invoked by alias); 15 Jan 2014 16:25:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26326 invoked by uid 89); 15 Jan 2014 16:25:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 15 Jan 2014 16:25:24 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 395EE1166CD; Wed, 15 Jan 2014 11:25:22 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 5eLtfl4nZDJp; Wed, 15 Jan 2014 11:25:22 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C4B01116536; Wed, 15 Jan 2014 11:25:21 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 00461E0816; Wed, 15 Jan 2014 20:25:18 +0400 (RET) Date: Wed, 15 Jan 2014 16:25:00 -0000 From: Joel Brobecker To: Eli Zaretskii Cc: binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: small request regarding commits in binutils-gdb.git Message-ID: <20140115162518.GL4762@adacore.com> References: <20140115121251.GM4639@adacore.com> <83mwix44gh.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83mwix44gh.fsf@gnu.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-01/txt/msg00516.txt.bz2 > > > This last patch removes "partial" from the names of > > > expand_partial_symbol_names and map_partial_symbol_filenames. > > > It also renames expand_partial_symbol_names to match the > > > struct quick_symbol_functions "method" that it wraps: > > > expand_symtabs_matching. > > > > > > This patch also adds two parameters to expand_symtabs_matching > > > so that it can fully wrap the underlying quick_symbol_functions method. > > > This makes it usable in more places. > > > I thought of having a cover function that still had the same > > > signature as the old expand_partial_symbol_names function, > > > but I couldn't think of a good name, and it wasn't clear it was > > > worth it anyway. > > > > > > gdb/ChangeLog: > > > > > > * symfile.h (expand_symtabs_matching): Renamed from > > > expand_partial_symbol_names. Update prototype. > > > (map_symbol_filenames): Renamed from map_partial_symbol_filenames. > > > * symfile.c (expand_symtabs_matching): Renamed from > > The text before the log entry is just a long way of saying the same > thing as the log entry, isn't it? It repeats the info that is already > in the log entry. Why does it make sense to repeat all that? I agree I could have chosen a more demonstrative example... But even with this example, it isn't just a repeat. The text before the ChangeLog says what the intent of the patch is, and provides extra information that usually doesn't go into the ChangeLog entry. For example, it says "This makes it usable in more places". -- Joel