From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8294 invoked by alias); 7 Jan 2014 18:47:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8285 invoked by uid 89); 7 Jan 2014 18:47:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 07 Jan 2014 18:47:33 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s07IlK5a003715 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 7 Jan 2014 13:47:20 -0500 Received: from host2.jankratochvil.net (ovpn-116-30.ams2.redhat.com [10.36.116.30]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s07IlHxZ005851 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Tue, 7 Jan 2014 13:47:19 -0500 Date: Tue, 07 Jan 2014 18:47:00 -0000 From: Jan Kratochvil To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [patchv4 4/5] Keep objfile original filename Message-ID: <20140107184716.GA12455@host2.jankratochvil.net> References: <20130919135631.GD16978@host2.jankratochvil.net> <52CC02B1.9060607@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52CC02B1.9060607@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00158.txt.bz2 On Tue, 07 Jan 2014 14:35:45 +0100, Yao Qi wrote: > We add an argument name here, but don't update > spu_symbol_file_add_from_memory in spu-linux-nat.c. We get a build > error below, when we build GDB with --target=spu-elf on powerpc-linux > machine. Sorry I did not build GDB on all archs; despite I have ppc accessible. > This patch fixes the build error, but I am not sure NAME we passed to > symbol_file_add_from_bfd is desired. IIUC, the NAME is "". > I didn't run testsuite. Is it OK? Yes, it is OK. The parameter is there for a difference for real disk files between their original name with symlinks vs. their realpath() name. Thanks, Jan > --- a/gdb/spu-linux-nat.c > +++ b/gdb/spu-linux-nat.c > @@ -379,7 +379,8 @@ spu_symbol_file_add_from_memory (int inferior_fd) > { > struct cleanup *cleanup = make_cleanup_bfd_unref (nbfd); > > - symbol_file_add_from_bfd (nbfd, SYMFILE_VERBOSE | SYMFILE_MAINLINE, > + symbol_file_add_from_bfd (nbfd, bfd_get_filename (nbfd), > + SYMFILE_VERBOSE | SYMFILE_MAINLINE, > NULL, 0, NULL); > do_cleanups (cleanup); > } > -- > 1.7.7.6