From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-108771-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 17238 invoked by alias); 28 Dec 2013 03:35:24 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 17228 invoked by uid 89); 28 Dec 2013 03:35:22 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2
X-HELO: rock.gnat.com
Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Sat, 28 Dec 2013 03:35:22 +0000
Received: from localhost (localhost.localdomain [127.0.0.1])	by filtered-rock.gnat.com (Postfix) with ESMTP id 3FBB9116570;	Fri, 27 Dec 2013 22:35:19 -0500 (EST)
Received: from rock.gnat.com ([127.0.0.1])	by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024)	with LMTP id VYxGmMdKZnKx; Fri, 27 Dec 2013 22:35:19 -0500 (EST)
Received: from joel.gnat.com (localhost.localdomain [127.0.0.1])	by rock.gnat.com (Postfix) with ESMTP id C46B311656B;	Fri, 27 Dec 2013 22:35:18 -0500 (EST)
Received: by joel.gnat.com (Postfix, from userid 1000)	id 867CEE0833; Sat, 28 Dec 2013 07:35:14 +0400 (RET)
Date: Sat, 28 Dec 2013 03:35:00 -0000
From: Joel Brobecker <brobecker@adacore.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: Yufeng Zhang <Yufeng.Zhang@arm.com>,	GDB Patches <gdb-patches@sourceware.org>,	Marcus Shawcroft <Marcus.Shawcroft@arm.com>,	Tom Tromey <tromey@redhat.com>
Subject: Re: [PATCH v2] Fix for PR tdep/15653: Implement SystemTap SDT probe support for AArch64
Message-ID: <20131228033514.GE4532@adacore.com>
References: <m38uvgmqjk.fsf@redhat.com> <52B86A61.1010004@arm.com> <m3ioufjxk2.fsf@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m3ioufjxk2.fsf@redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-SW-Source: 2013-12/txt/msg00975.txt.bz2

> 2013-12-23  Sergio Durigan Junior  <sergiodj@redhat.com>
> 
> 	* NEWS: Mention SystemTap SDT probe support for AArch64 GNU/Linux.
> 	* aarch64-linux-tdep.c: Include necessary headers for parsing of
> 	SystemTap SDT probes.
> 	(aarch64_stap_is_single_operand): New function.
> 	(aarch64_stap_parse_special_token): Likewise.
> 	(aarch64_linux_init_abi): Declare SystemTap SDT probe argument
> 	prefixes and suffixes.  Initialize gdbarch with them.

First of all, thanks to Yufeng and Marcus for reviewing the patch.
That was very useful.

The patch is therefore approved, with one small request:

>  }
>  
> +static int
> +aarch64_stap_is_single_operand (struct gdbarch *gdbarch, const char *s)
> +{
> +  return (*s == '#' || isdigit (*s) /* Literal number.  */
> +	  || *s == '[' /* Register indirection.  */
> +	  || isalpha (*s)); /* Register value.  */
> +}

Can you document this function?

Thank you,
-- 
Joel