From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5717 invoked by alias); 23 Dec 2013 00:41:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5707 invoked by uid 89); 23 Dec 2013 00:41:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 23 Dec 2013 00:41:52 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 64E3F11646A; Sun, 22 Dec 2013 19:42:31 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id kACkUGLlRZAv; Sun, 22 Dec 2013 19:42:31 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id E891E116432; Sun, 22 Dec 2013 19:42:30 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 18CF5E0CB6; Mon, 23 Dec 2013 04:41:46 +0400 (RET) Date: Mon, 23 Dec 2013 00:41:00 -0000 From: Joel Brobecker To: asmwarrior Cc: "gdb-patches@sourceware.org" Subject: Re: [RFC, doc] fix document error on the grammar of GDB/MI output format syntax Message-ID: <20131223004146.GB4605@adacore.com> References: <52B69693.10107@gmail.com> <20131222080903.GA4605@adacore.com> <52B6CDAB.1020303@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="qMm9M+Fa2AknHoGS" Content-Disposition: inline In-Reply-To: <52B6CDAB.1020303@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-12/txt/msg00866.txt.bz2 --qMm9M+Fa2AknHoGS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 1074 > Looking at your patch. > > -@code{[ @var{token} ] "+" @var{async-output}} > > +@code{[ @var{token} ] "+" @var{async-output}} @var{nl} > Is it OK to put the @var{nl} inside the @code{}? OK, thank you and Eli for pointing this out and confirming it. Attached is the updated patch. > Because I see some (removed) code in your patch: > > -@code{@var{async-class} ( "," @var{result} )* @var{nl}} > I'm not familiar with the Texinfo grammar. I won't say that I am extremely comfortable with it, yet, but I'm slowly getting there... Basically, the "nl" has been moved to the varous rules that use this rule (exec-async-output, status-async-output and notify-async-output). The idea is, as hinted in the patch's rev log, to keep the special symbol indicating the type of output, and the nl, within the same rule. gdb/doc/ChangeLog: (from Yao Qi ) (from Joel Brobecker ) * gdb.texinfo (GDB/MI Output Syntax): Add some missing "nl" markers. Remove one that was misplaced. OK to apply? -- Joel --qMm9M+Fa2AknHoGS Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-Small-fixes-to-the-GDB-MI-Output-Syntax-grammar.patch" Content-length: 2245 >From a838547bbecd611cedd059911d95c6790871d63e Mon Sep 17 00:00:00 2001 From: Joel Brobecker Date: Mon, 23 Dec 2013 04:25:14 +0400 Subject: [PATCH] Small fixes to the GDB/MI Output Syntax grammar. This patch fixes the grammar, and tries to do it in a way that makes the logic behind the current implementation a little clearer. gdb/doc/ChangeLog: (from Yao Qi ) (from Joel Brobecker ) * gdb.texinfo (GDB/MI Output Syntax): Add some missing "nl" markers. Remove one that was misplaced. --- gdb/doc/gdb.texinfo | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index b7551c2..f852c53 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -29166,16 +29166,16 @@ corresponding output for that command will also be prefixed by that same @code{@var{exec-async-output} | @var{status-async-output} | @var{notify-async-output}} @item @var{exec-async-output} @expansion{} -@code{[ @var{token} ] "*" @var{async-output}} +@code{[ @var{token} ] "*" @var{async-output nl}} @item @var{status-async-output} @expansion{} -@code{[ @var{token} ] "+" @var{async-output}} +@code{[ @var{token} ] "+" @var{async-output nl}} @item @var{notify-async-output} @expansion{} -@code{[ @var{token} ] "=" @var{async-output}} +@code{[ @var{token} ] "=" @var{async-output nl}} @item @var{async-output} @expansion{} -@code{@var{async-class} ( "," @var{result} )* @var{nl}} +@code{@var{async-class} ( "," @var{result} )*} @item @var{result-class} @expansion{} @code{"done" | "running" | "connected" | "error" | "exit"} @@ -29207,13 +29207,13 @@ depending on the needs---this is still in development). @code{@var{console-stream-output} | @var{target-stream-output} | @var{log-stream-output}} @item @var{console-stream-output} @expansion{} -@code{"~" @var{c-string}} +@code{"~" @var{c-string nl}} @item @var{target-stream-output} @expansion{} -@code{"@@" @var{c-string}} +@code{"@@" @var{c-string nl}} @item @var{log-stream-output} @expansion{} -@code{"&" @var{c-string}} +@code{"&" @var{c-string nl}} @item @var{nl} @expansion{} @code{CR | CR-LF} -- 1.8.3.2 --qMm9M+Fa2AknHoGS--