From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15652 invoked by alias); 17 Dec 2013 11:08:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15640 invoked by uid 89); 17 Dec 2013 11:08:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Dec 2013 11:08:47 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBHB8ksX015458 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 17 Dec 2013 06:08:46 -0500 Received: from blade.nx (ovpn-116-102.ams2.redhat.com [10.36.116.102]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rBHB8jg6009616; Tue, 17 Dec 2013 06:08:46 -0500 Received: by blade.nx (Postfix, from userid 1000) id DF5D1262381; Tue, 17 Dec 2013 11:08:44 +0000 (GMT) Date: Tue, 17 Dec 2013 11:08:00 -0000 From: Gary Benson To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/4] change probes to be program-space-independent Message-ID: <20131217110844.GA15900@blade.nx> Mail-Followup-To: Tom Tromey , gdb-patches@sourceware.org References: <1386100019-27379-1-git-send-email-tromey@redhat.com> <1386100019-27379-4-git-send-email-tromey@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1386100019-27379-4-git-send-email-tromey@redhat.com> X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00622.txt.bz2 Tom Tromey wrote: > This changes the probes to be independent of the program space. > > After this, when a probe's address is needed, it is determined by > applying offsets at the point of use. > > This introduces a bound_probe object, similar to bound minimal > symbols. Objects of this type are used when it's necessary to pass a > probe and its corresponding objfile. > > This removes the backlink from probe to objfile, which was primarily > used to fetch the architecture to use. > > This adds a get_probe_address function which calls a probe method to > compute the probe's relocated address. Similarly, it adds an objfile > parameter to the semaphore methods so they can do the relocation > properly as well. I haven't looked at the whole patch, but the solib-svr4.c bits look good. Thanks for doing this work Tom. Cheers, Gary -- http://gbenson.net/