Re: [PATCH] Extend SystemTap SDT probe argument parser

Sergio Durigan Junior
2013-12-16T17:16:17Z

On Monday, December 16 2013, Mark Kettenis wrote:

>> From: Sergio Durigan Junior <sergiodj@redhat.com>
>> Date: Mon, 16 Dec 2013 15:01:38 -0200
>>
>> On Wednesday, December 11 2013, I wrote:
>>
>> > This patch extends the current generic parser for SystemTap SDT probe
>> > arguments. It can be almost considered a cleanup, but the main point of
>> > it is actually to allow the generic parser to accept multiple prefixes
>> > and suffixes for the its operands (i.e., integers, register names, and
>> > register indirection).
>>
>> Ping.
>
> Can't say I like the added complexity, but the i386/amd64 are ok.

Thanks for the approval.

I wonder what exactly you didn't like, and if you have some opinion on
how to improve it.

Thanks,

--
Sergio