From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5834 invoked by alias); 14 Dec 2013 23:11:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5818 invoked by uid 89); 14 Dec 2013 23:11:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-yh0-f49.google.com Received: from mail-yh0-f49.google.com (HELO mail-yh0-f49.google.com) (209.85.213.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 14 Dec 2013 23:10:59 +0000 Received: by mail-yh0-f49.google.com with SMTP id z20so2668116yhz.36 for ; Sat, 14 Dec 2013 15:10:57 -0800 (PST) X-Received: by 10.236.92.138 with SMTP id j10mr1272622yhf.70.1387062657795; Sat, 14 Dec 2013 15:10:57 -0800 (PST) Received: from gnu-tools-1.localdomain (76-220-57-190.lightspeed.sntcca.sbcglobal.net. [76.220.57.190]) by mx.google.com with ESMTPSA id q44sm10638053yhg.10.2013.12.14.15.10.56 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 14 Dec 2013 15:10:57 -0800 (PST) Received: by gnu-tools-1.localdomain (Postfix, from userid 1000) id D95F54045E; Sat, 14 Dec 2013 15:10:55 -0800 (PST) Date: Sat, 14 Dec 2013 23:11:00 -0000 From: "H.J. Lu" To: Mark Kettenis Cc: GDB Subject: Re: [PATCH 2/3] PR gdb/16304: Add amd64_x32_linux_record_tdep and amd64_x32_sys_xxx Message-ID: <20131214231055.GA3792@gmail.com> References: <20131208194419.GB10094@intel.com> <20131209000758.GA15600@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131209000758.GA15600@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00553.txt.bz2 On Sun, Dec 08, 2013 at 04:07:58PM -0800, H.J. Lu wrote: > On Sun, Dec 08, 2013 at 11:44:19AM -0800, H.J. Lu wrote: > > Hi, > > > > X32 Linux system calls are diffferent from amd64 Linux system calls > > in system call numbers as well as parameter types/values. We can't use > > amd64_linux_record_tdep for x32. This patch adds x32 system call > > numbers. It also adds linux_record_tdep_p to gdbarch_tdep so that > > we can use different linux_record_tdeps for x32 and amd64. > > linux_record_tdep_p will be unused for other x86 targets. Tested on > > Linux/x86-64. OK to install? > > > > > > Here is the updated patch with amd64_x32_linux_syscall_record. > Tested on Linux/x86-64. OK to install? > > Thanks. > > > H.J. > --- > 2013-12-08 H.J. Lu > > PR gdb/16304 > * amd64-linux-tdep.c (amd64_canonicalize_syscall): Handle x32 > system calls. > (amd64_x32_linux_record_tdep): New. > (amd64_linux_syscall_record_common): New function. > (amd64_linux_syscall_record): Call > amd64_linux_syscall_record_common with amd64_linux_record_tdep. > (amd64_x32_linux_syscall_record): Call > amd64_linux_syscall_record_common with > amd64_x32_linux_record_tdep. > (amd64_linux_init_abi_common): Move amd64_linux_record_tdep > initialization and tdep->i386_syscall_record setup to ... > (amd64_linux_init_abi): Here. > (amd64_x32_linux_init_abi): Initialize > amd64_x32_linux_record_tdep. Set tdep->i386_syscall_record to > amd64_x32_linux_syscall_record. > * amd64-linux-tdep.h (amd64_x32_syscall): New enum. > Hi Mark, Does it look OK? The patch is at https://sourceware.org/ml/gdb-patches/2013-12/msg00313.html Thanks. H.J.