From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32744 invoked by alias); 12 Dec 2013 09:13:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32731 invoked by uid 89); 12 Dec 2013 09:13:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 Dec 2013 09:13:00 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBC9Cwfa025788 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 12 Dec 2013 04:12:58 -0500 Received: from host2.jankratochvil.net (ovpn-116-40.ams2.redhat.com [10.36.116.40]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rBC9Cs1h028826 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Thu, 12 Dec 2013 04:12:57 -0500 Date: Thu, 12 Dec 2013 09:13:00 -0000 From: Jan Kratochvil To: "Metzger, Markus T" Cc: "gdb-patches@sourceware.org" , Pedro Alves Subject: Re: [patch v7 22/24] btrace, gdbserver: read branch trace incrementally Message-ID: <20131212091254.GA20414@host2.jankratochvil.net> References: <1385735899-12481-1-git-send-email-markus.t.metzger@intel.com> <1385735899-12481-23-git-send-email-markus.t.metzger@intel.com> <20131211195820.GB22687@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00464.txt.bz2 On Thu, 12 Dec 2013 09:23:46 +0100, Metzger, Markus T wrote: > What this function does is stitch the old and new trace together by inserting > the last instruction of the old trace as beginning of the chronologically first > block of the new trace. Then it removes the last instruction from the old > trace - it will be re-added when we process the new trace. > > I renamed the variables as follows: > end -> last_bfun > insn -> last_insn > block -> first_new_block Yes, I find those names helpful. Thanks, Jan