From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-108245-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4188 invoked by alias); 11 Dec 2013 19:57:59 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 4177 invoked by uid 89); 11 Dec 2013 19:57:58 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS,UNWANTED_LANGUAGE_BODY autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Dec 2013 19:57:58 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBBJvvPD029793	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 11 Dec 2013 14:57:57 -0500
Received: from host2.jankratochvil.net (ovpn-116-40.ams2.redhat.com [10.36.116.40])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rBBJvreJ031851	(version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO);	Wed, 11 Dec 2013 14:57:56 -0500
Date: Wed, 11 Dec 2013 19:57:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Markus Metzger <markus.t.metzger@intel.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch v7 21/24] record-btrace: extend unwinder
Message-ID: <20131211195753.GA22687@host2.jankratochvil.net>
References: <1385735899-12481-1-git-send-email-markus.t.metzger@intel.com> <1385735899-12481-22-git-send-email-markus.t.metzger@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1385735899-12481-22-git-send-email-markus.t.metzger@intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-IsSubscribed: yes
X-SW-Source: 2013-12/txt/msg00449.txt.bz2

On Fri, 29 Nov 2013 15:38:16 +0100, Markus Metzger wrote:
> --- a/gdb/frame.c
> +++ b/gdb/frame.c
> @@ -335,6 +335,11 @@ fprint_frame_type (struct ui_file *file, enum frame_type type)
>        return;
>      case SENTINEL_FRAME:
>        fprintf_unfiltered (file, "SENTINEL_FRAME");

Missing 'return;'.


> +    case BTRACE_FRAME:
> +      fprintf_unfiltered (file, "BTRACE_FRAME");
> +      return;
> +    case BTRACE_TAILCALL_FRAME:
> +      fprintf_unfiltered (file, "BTRACE_TAILCALL_FRAME");
>        return;
>      default:
>        fprintf_unfiltered (file, "<unknown type>");


Thanks,
Jan