From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5318 invoked by alias); 11 Dec 2013 17:02:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5309 invoked by uid 89); 11 Dec 2013 17:02:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from Unknown (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 11 Dec 2013 17:02:14 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 0861C1163C3; Wed, 11 Dec 2013 12:02:45 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id j0AzH0tCJnmi; Wed, 11 Dec 2013 12:02:44 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id D036711636E; Wed, 11 Dec 2013 12:02:44 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id A6E6CE059D; Wed, 11 Dec 2013 18:02:04 +0100 (CET) Date: Wed, 11 Dec 2013 17:02:00 -0000 From: Joel Brobecker To: Pierre Muller Cc: gdb-patches@sourceware.org Subject: Re: [PING RFA] Fix PR 16201: internal error on a cygwin program linked against a DLL with no .data section Message-ID: <20131211170204.GD3227@adacore.com> References: <004801cef65e$cb82d1b0$62887510$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <004801cef65e$cb82d1b0$62887510$@muller@ics-cnrs.unistra.fr> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-12/txt/msg00440.txt.bz2 > and an answer from Joel stating that he would prefer > that someone else with more knowledge about objfile struct > would review my RFA... > https://sourceware.org/ml/gdb-patches/2013-12/msg00036.html > > We got no other reaction yet. > > Should I press Joel to review it nonetheless > or does someone else volunteer to review this patch? I just re-read the code, and I really think it would be better if someone who actually understands the general framework could comment. The problem seems, as you stated, relatively well understood, but I am not sure how we are expected to fix it. > 2013-11-27 Pierre Muller > > PR 16201 > coff-pe-read.c (read_pe_exported_syms): Set sect_index_text, > sect_index_data and sect_index_bss of objfile struct, even if > there is no canonical '.text', '.data' or '.bss' named section. My only comment is that the patch could gain from some additional comments explaining _why_ you're forcing the sect_index field ("event if already set before"), and what you are trying to achieve. > > diff --git a/gdb/coff-pe-read.c b/gdb/coff-pe-read.c > index 91ee3f6..954c457 100644 > --- a/gdb/coff-pe-read.c > +++ b/gdb/coff-pe-read.c > @@ -466,6 +466,13 @@ read_pe_exported_syms (struct objfile *objfile) > { > section_data[sectix].rva_start = vaddr; > section_data[sectix].rva_end = vaddr + vsize; > + /* Force sect_index, even if it was already set before. */ > + if (sectix == PE_SECTION_INDEX_TEXT) > + objfile->sect_index_text = sectix; > + if (sectix == PE_SECTION_INDEX_DATA) > + objfile->sect_index_data = sectix; > + if (sectix == PE_SECTION_INDEX_BSS) > + objfile->sect_index_bss = sectix; > } > else > { > @@ -480,11 +487,23 @@ read_pe_exported_syms (struct objfile *objfile) > section_data[otherix].rva_end = vaddr + vsize; > section_data[otherix].vma_offset = 0; > if (characteristics & IMAGE_SCN_CNT_CODE) > - section_data[otherix].ms_type = mst_text; > + { > + section_data[otherix].ms_type = mst_text; > + if (objfile->sect_index_text == -1) > + objfile->sect_index_text = otherix; > + } > else if (characteristics & IMAGE_SCN_CNT_INITIALIZED_DATA) > - section_data[otherix].ms_type = mst_data; > + { > + section_data[otherix].ms_type = mst_data; > + if (objfile->sect_index_data == -1) > + objfile->sect_index_data = otherix; > + } > else if (characteristics & IMAGE_SCN_CNT_UNINITIALIZED_DATA) > - section_data[otherix].ms_type = mst_bss; > + { > + section_data[otherix].ms_type = mst_bss; > + if (objfile->sect_index_bss == -1) > + objfile->sect_index_bss = otherix; > + } > else > section_data[otherix].ms_type = mst_unknown; > otherix++; -- Joel