From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4702 invoked by alias); 5 Dec 2013 03:45:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4689 invoked by uid 89); 5 Dec 2013 03:45:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.5 required=5.0 tests=AWL,BAYES_50 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from Unknown (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 05 Dec 2013 03:45:03 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 887331168B1; Wed, 4 Dec 2013 22:45:33 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 6Y2NGEYUrjKp; Wed, 4 Dec 2013 22:45:33 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 2C01B116854; Wed, 4 Dec 2013 22:45:33 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 59233EB160; Thu, 5 Dec 2013 07:44:51 +0400 (RET) Date: Thu, 05 Dec 2013 03:45:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Allow Windows UNWIND_INFO version 2. Message-ID: <20131205034451.GD3175@adacore.com> References: <1386070345-8237-1-git-send-email-brobecker@adacore.com> <529E274D.607@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <529E274D.607@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-12/txt/msg00167.txt.bz2 > I'd consider merging with the existing loop, so that > we print the opcodes when frame debug is enabled. > > But anyway, this looks fine to me. Thanks, Pedro. Given Tristan's feedback, I decided to push the patch as is. But I remain available to make additional changes, should the discussion lead us towards that. > I clicked on "Did you find this helpful? No" at: > > http://msdn.microsoft.com/en-us/library/ck9asaa9.aspx > > and asked for info about v2 and opcode 6. Not holding > my breath though. Ha! Good idea, and I will remember to do that too. It's not much effort, and you never know. -- Joel