Re: [PATCH] testsuite: sigall.exp: handle SIGLOST/SIGPWR conflict in sparc64 targets

Mark Kettenis
2013-12-03T12:07:36Z

> From: jose.marchesi@oracle.com (Jose E. Marchesi)
> Date: Tue, 03 Dec 2013 12:59:02 +0100
>
> ping
>
> Hi.
>
> In sparc64 SIGLOST and SIGPWR have the same signal number. The
> following patch fixes gdb.base/sigall.exp accordingly.
>
> Tested in sparc64-unknown-linux-gnu.
>
> 2013-10-23 Jose E. Marchesi <jose.marchesi@oracle.com>
>
> * gdb.base/sigall.exp (test_one_sig): gdb identifies SIGLOST as a
> SIGPWR in sparc64.
>
> * gdb.base/sigall.c (main): In some targets SIGLOST and SIGPWR
> have the same signal number. Handle this situation.

Small nit:

> diff --git a/gdb/testsuite/gdb.base/sigall.exp b/gdb/testsuite/gdb.base/sigall.exp
> index b1b8597..4bfb199 100644
> --- a/gdb/testsuite/gdb.base/sigall.exp
> +++ b/gdb/testsuite/gdb.base/sigall.exp
> @@ -39,12 +39,20 @@ proc test_one_sig {nextsig} {
> set need_another_continue 1
> set missed_handler 0
> if $this_sig_supported then {
> + set esig $thissig
> +
> if { $thissig == "IO" } {
> setup_xfail "i*86-pc-linuxoldld-gnu" "i*86-pc-linuxaout-gnu"
> }
> + # In SPARC64 systems SIGLOST==SIGPWR and gdb identifies the raised
> + # signal as PWR.

Change that into "On Linux SPARC64 systems..."

With that change, this is fine with me.