From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32593 invoked by alias); 3 Dec 2013 10:18:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32584 invoked by uid 89); 3 Dec 2013 10:18:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.9 required=5.0 tests=AWL,BAYES_50,RDNS_NONE autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from Unknown (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 03 Dec 2013 10:18:36 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 7FC6B1163AE; Tue, 3 Dec 2013 05:19:06 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Lo7wajS+IR-8; Tue, 3 Dec 2013 05:19:06 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 158A61163B3; Tue, 3 Dec 2013 05:19:06 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 683BDE081D; Tue, 3 Dec 2013 14:18:25 +0400 (RET) Date: Tue, 03 Dec 2013 10:18:00 -0000 From: Joel Brobecker To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [RFA/commit+doco] GDB/MI: Document support for -exec-run --start in -list-features Message-ID: <20131203101825.GD3114@adacore.com> References: <1386051670-28637-1-git-send-email-brobecker@adacore.com> <83wqjm4cwl.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83wqjm4cwl.fsf@gnu.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-12/txt/msg00070.txt.bz2 > > gdb/ChangeLog: > > > > * mi/mi-main.c (mi_cmd_list_features): add "exec-run-start-option". > > * NEWS: Expand the entry documenting the new -exec-run --start > > option to mention the corresponding new entry in the output of > > "-list-features". > > > > gdb/doc/ChangeLog: > > > > * gdb.texinfo (GDB/MI Miscellaneous Commands): Document the new > > "exec-run-start-option" entry in the output of the "-list-features" > > command. > > > > gdb/testsuite/ChangeLog: > > > > * gdb.mi/mi-start.exp: Add test verifying that -list-features > > contains "exec-run-start-option". > > > > Tested on x86_64-linux. Both code and doco parts are relatively > > straightforward, so I am planning on checking this in in a day or > > two, assuming doco approval. > > You have my approval, with one comment: each one of the items in that > @table in gdb.texinfo should be indexed, to facilitate their > discoverability by readers. E.g., for this item I'd suggest > > @findex exec-run-start-option > @cindex support for @option{--start} option in @code{-exec-run} > > I'd also add an index entry for the entire section > > @cindex supported @sc{gdb/mi} features, list > > >From the past couple of weeks, it sounds like this section will grow > very fast (so maybe it should become a full-fledged @node). Thanks, Eli. I will prepare a followup patch as soon as this one gets in. I don't see the section growing very fast, now that we have -info-gdb-mi-commands, so it would be mostly for new switches. But I do agree with all suggestions overall. -- Joel