From: Joel Brobecker <brobecker@adacore.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Fix PR 16201: internal error on a cygwin program linked against a DLL with no .data section
Date: Mon, 02 Dec 2013 14:10:00 -0000 [thread overview]
Message-ID: <20131202141017.GW3114@adacore.com> (raw)
In-Reply-To: <000001ceef67$6414ae70$2c3e0b50$@muller@ics-cnrs.unistra.fr>
> But could you elaborate onto why you are unsure about the patch?
> What is bothering you?
Sure. I may have expressed myself poorly. The patch wasn't obvious,
and I didn't have time to look into it more closely. So if I were
the one reviewing it, I'd need a small chunk of free time to really
understand it well, and double-check its possible unwanted side-effects.
Maybe someone else, who is more familiar with objfiles et al, might
find it easier to review.
--
Joel
prev parent reply other threads:[~2013-12-02 14:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 1:23 Pierre Muller
2013-12-02 3:30 ` Joel Brobecker
2013-12-02 10:44 ` Pierre Muller
2013-12-02 11:37 ` Joel Brobecker
2013-12-02 14:04 ` Pierre Muller
2013-12-02 14:10 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131202141017.GW3114@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox