From: Joel Brobecker <brobecker@adacore.com>
To: Chung-Lin Tang <cltang@codesourcery.com>
Cc: gdb-patches@sourceware.org, Sandra Loosemore <sandra@codesourcery.com>
Subject: Re: [patch, nios2] Update Linux parts for new syscall ABI
Date: Mon, 02 Dec 2013 03:23:00 -0000 [thread overview]
Message-ID: <20131202032333.GN3114@adacore.com> (raw)
In-Reply-To: <529AF143.9060704@codesourcery.com>
> This patch updates the nios2-linux code for the new Linux generic system
> call interface. Mainly removing (non-rt) sigreturn related definitions,
> and updating the rt_sigreturn syscall NR.
>
> Will commit after Sandra's approval.
I am sorry to be so procedural, but while Sandra input would probably
be more valuable than most, Sandra is not yet listed as maintainer
in GDB. She can therefore not approve patches for commit in the official
repository yet. It should all be documented in gdb/MAINTAINERS.
> 2013-12-01 Chung-Lin Tang <cltang@codesourcery.com>
>
> gdb/
> * nios2-linux-tdep.c (nios2_linux_sigreturn_init): Remove.
> (nios2_linux_sigreturn_tramp_frame): Remove.
> (nios2_linux_rt_sigreturn_tramp_frame): Update rt_sigreturn syscall
> number.
> (nios2_linux_syscall_next_pc): Likewise. Remove sigreturn case.
> (nios2_linux_init_abi):
> Remove registration of nios2_linux_sigreturn_tramp_frame.
My concern with your patch is that it seems to eliminate support for
the previous syscall ABI, which means a break in compatibility. Unless
we really have no other choice, I don't think we would want that.
--
Joel
next prev parent reply other threads:[~2013-12-02 3:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-01 8:20 Chung-Lin Tang
2013-12-02 3:23 ` Joel Brobecker [this message]
2013-12-02 4:46 ` Chung-Lin Tang
2013-12-02 7:44 ` Joel Brobecker
2013-12-02 8:38 ` Chung-Lin Tang
2013-12-02 16:20 ` Sandra Loosemore
2013-12-03 3:01 ` Joel Brobecker
2013-12-10 6:55 ` Yao Qi
2013-12-03 3:07 ` Joel Brobecker
2013-12-20 13:16 ` Chung-Lin Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131202032333.GN3114@adacore.com \
--to=brobecker@adacore.com \
--cc=cltang@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=sandra@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox