From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11982 invoked by alias); 30 Nov 2013 08:57:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11967 invoked by uid 89); 30 Nov 2013 08:57:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: smtp.gentoo.org Received: from Unknown (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 30 Nov 2013 08:57:31 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id EC37833F371; Sat, 30 Nov 2013 08:57:23 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: Re: [PATCH] Add MIPS UFR support Date: Sat, 30 Nov 2013 09:59:00 -0000 User-Agent: KMail/1.13.7 (Linux/3.12.1; KDE/4.6.5; x86_64; ; ) Cc: Andrew Bennett References: <0DA23CC379F5F945ACB41CF394B982774C8579@LEMAIL01.le.imgtec.org> In-Reply-To: <0DA23CC379F5F945ACB41CF394B982774C8579@LEMAIL01.le.imgtec.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2277765.kZ1d0xN21s"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201311300357.23710.vapier@gentoo.org> X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00956.txt.bz2 --nextPart2277765.kZ1d0xN21s Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-length: 2291 On Friday 08 November 2013 12:36:45 Andrew Bennett wrote: > This patch adds support to the MIPS backend to deal with changing the FR > mode in user mode (which I will now refer to as UFR). The technical > details are explained in the following paragraph. >=20 > The read only field UFR (at bit 28) in the floating point implementation > register (CP1 control register 0) represents if the CPU supports UFR. The > UFR field (bit 2) in configuration register 5 (CP0 register 16, select 5) > allows user mode to enable or disable UFR support. The current value of > the FR mode can be obtained if a read is made from the UFR register (CP1 > control register 1), and UFR support is enabled. If register zero is > written to the UFR register, and UFR support is enabled, then the FR mode > is set to 0. If register zero is written to the UNFR register (CP1 control > register 4), and the UFR support is enabled, then the FR mode is set to 1. >=20 > To implement this I have firstly added the config 5 register to the > simulator model, and added support to read and write to it. Secondly, I > have added support for the CTC1 and CFC1 instructions to write/read > to/from the UFR and UNFR registers. is this standard functionality available to all CPUs ? your new status_UFR= P=20 bit overlaps with the existing status_CU0 bit, and you unconditionally enab= le=20 this feature. > I have also added a testcase to validate the implementation. To run the > testcase you will need to apply the following binutils patch: >=20 > https://sourceware.org/ml/binutils/2013-11/msg00065.html >=20 >=20 > The simulator patch is attached to this email and the ChangeLog is shown > below. looks like your comments need tweaking to follow GNU style. that means a=20 period at the end followed by two spaces and then the closing */. i also s= ee=20 "Unpredictable();" and that needs a space before the "(". in your mips.igen change, the code changes the else case from a NOP to=20 Unpredictable(). is that really what you want ? > This is my first patch to gdb, so I am unsure the protocol on committing.= =20 > Would someone be able to clarify? does your employer have copyright assignments in place ? otherwise, we don't have a MIPS sim maintainer atm, so i'll do a crappy sta= nd- in job. -mike --nextPart2277765.kZ1d0xN21s Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJSmahzAAoJEEFjO5/oN/WBvcIQAN1tgR3eCcA7jTnH2zO6llAW Xu6V0aMYhT/pBrkxPjWzycSNauITvg67jtRgdrAhAFIUZ/IFHegrDBcKHqmmCltH m7eU70yKnvuAIdYN5Q0vFE10IILQsJgAwHLJZORPrmvqGd5iNxmAPwVUJDZUNXXi 0rR5i674FJPVWnDeAsScyWSa6+AEto4gAWexbB+kr7pixkZUAS0jDJCPczVReHt0 zlQ/n4/pdi8WzZHXbIIIrp0M5lwH3zMbGFqFgrDvErUkQdgGX5lAv3aLlOfLh4d0 +4NOB72QklX5I7b5QZaEOrML56JQJhfhM+UzMD69Gf59tyiiy1ci8WUb8Zg9YLPm hlx0Z/FzUXq6wVo/pAfF7QGPstYHjrU1Ar65RI9CGozlsL+2H6UlqiRDQILl7OXl CoUWVI4wMxoI/RRtUJODIbLBQqxSgDwhpi68u7jyU5xD6sPRgGfRSK+i6v4Ej1IC SGEhbFlakMkTJGIrXra0dEQ9vFXCgCDQmuK1ME6iFZkWHGIY7juHbjRp+GZ7MtZJ grt7qzOPUuemGdw4OwWy2F9J1RrJ4bWsU7tVZgJoOwZKxjR84FZz6Bw4pFLmj09h z9VJycIGSwyHLDpt4ltzcFYVq4mrMzHZGqX1MxK36ST+cJ8qIOg6rffG1XAsYlMx L6ZoJhcggg5OntcbC5QU =Asus -----END PGP SIGNATURE----- --nextPart2277765.kZ1d0xN21s--