From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32714 invoked by alias); 29 Nov 2013 16:05:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32703 invoked by uid 89); 29 Nov 2013 16:05:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.5 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: glazunov.sibelius.xs4all.nl Received: from Unknown (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 29 Nov 2013 16:05:48 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id rATG5YUK004167; Fri, 29 Nov 2013 17:05:34 +0100 (CET) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id rATG5XVb030184; Fri, 29 Nov 2013 17:05:33 +0100 (CET) Date: Fri, 29 Nov 2013 18:55:00 -0000 Message-Id: <201311291605.rATG5XVb030184@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: mark.kettenis@xs4all.nl CC: yao@codesourcery.com, gdb-patches@sourceware.org In-reply-to: <201311291436.rATEaZ5Z030292@glazunov.sibelius.xs4all.nl> (message from Mark Kettenis on Fri, 29 Nov 2013 15:36:36 +0100 (CET)) Subject: Re: [PATCH 2/3] skip_prolgoue (amd64) References: <1385735051-27558-1-git-send-email-yao@codesourcery.com> <1385735051-27558-3-git-send-email-yao@codesourcery.com> <201311291436.rATEaZ5Z030292@glazunov.sibelius.xs4all.nl> X-SW-Source: 2013-11/txt/msg00939.txt.bz2 > Date: Fri, 29 Nov 2013 15:36:36 +0100 (CET) > From: Mark Kettenis > > > From: Yao Qi > > Date: Fri, 29 Nov 2013 22:24:10 +0800 > > > > gdb: > > > > 2013-11-29 Yao Qi > > > > * amd64-tdep.c (amd64_analyze_stack_align): Call > > target_read_code instead of target_read_memory. > > (amd64_analyze_prologue): Call read_code_unsigned_integer > > instead of read_memory_unsigned_integer. Call read_code > > instead of read_memory. > > (amd64_skip_xmm_prologue): Likewise. > > Makes sense to me. But only if the cache is properly invalidated when control when running/stepping. Is it?