From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30985 invoked by alias); 26 Nov 2013 14:37:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30976 invoked by uid 89); 26 Nov 2013 14:37:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.1 required=5.0 tests=AWL,BAYES_05,RDNS_NONE autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from Unknown (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 26 Nov 2013 14:37:39 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D70EB11662C; Tue, 26 Nov 2013 09:38:06 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id HBVtSQowDze2; Tue, 26 Nov 2013 09:38:06 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 786B3116612; Tue, 26 Nov 2013 09:38:06 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id B99F2E0795; Tue, 26 Nov 2013 18:37:27 +0400 (RET) Date: Tue, 26 Nov 2013 14:42:00 -0000 From: Joel Brobecker To: Mark Kettenis Cc: tromey@redhat.com, gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] handle an unspecified return address column Message-ID: <20131126143727.GJ3114@adacore.com> References: <1384375873-32160-1-git-send-email-tromey@redhat.com> <1384375873-32160-3-git-send-email-tromey@redhat.com> <20131126133446.GA28596@adacore.com> <201311261348.rAQDmBs1032481@glazunov.sibelius.xs4all.nl> <20131126135519.GI3114@adacore.com> <201311261430.rAQEUFIu001724@glazunov.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201311261430.rAQEUFIu001724@glazunov.sibelius.xs4all.nl> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-11/txt/msg00813.txt.bz2 > Pretty much both. The original diff was clearly wrong, and it is best > to have the history reflect that clearly. But it will also make the > review easier. To be honest, I think the conditional, after your > modification, is too confusing. OK. It's Tom's commit, so I will wait for his input before undoing the change. > Didn't realize that the tests were part of the same commit though. So > you probably can't simply use git revert. Perhaps that means we > should commit testsuite changes seperately in the future. It's easy to undo just part of the commit, still keeping the testcase. We can't use "git revert" anyways, because of those $(&! ChangeLog files, nearly always triggerring revert conflict. And the sad part is that we actually want those, because we do not want to undo the ChangeLog entry! -- Joel