From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25545 invoked by alias); 26 Nov 2013 14:30:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25530 invoked by uid 89); 26 Nov 2013 14:30:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.5 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: glazunov.sibelius.xs4all.nl Received: from Unknown (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 26 Nov 2013 14:30:30 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id rAQEUFpL013808; Tue, 26 Nov 2013 15:30:15 +0100 (CET) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id rAQEUFIu001724; Tue, 26 Nov 2013 15:30:15 +0100 (CET) Date: Tue, 26 Nov 2013 14:41:00 -0000 Message-Id: <201311261430.rAQEUFIu001724@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: brobecker@adacore.com CC: tromey@redhat.com, gdb-patches@sourceware.org In-reply-to: <20131126135519.GI3114@adacore.com> (message from Joel Brobecker on Tue, 26 Nov 2013 17:55:19 +0400) Subject: Re: [PATCH 2/2] handle an unspecified return address column References: <1384375873-32160-1-git-send-email-tromey@redhat.com> <1384375873-32160-3-git-send-email-tromey@redhat.com> <20131126133446.GA28596@adacore.com> <201311261348.rAQDmBs1032481@glazunov.sibelius.xs4all.nl> <20131126135519.GI3114@adacore.com> X-SW-Source: 2013-11/txt/msg00812.txt.bz2 > Date: Tue, 26 Nov 2013 17:55:19 +0400 > From: Joel Brobecker > > > > gdb/ChangeLog: > > > > > > PR backtrace/16155: > > > * dwarf2-frame.c (dwarf2_frame_cache): Remove condition that > > > sets cache->undefined_retaddr to 1 if there is no column in > > > the frame info for the return register. > > > > > > Tested on x86_64-linux, no regression. It also fixes all regressions > > > observed on arm-elf and ppc-elf. > > > > > > Can you tell me what you think? > > > > Please start with backing out the original change. > > I would gladly do so, but can you explain the rationale behind your > request? Is it to facilitate review of this patch? Or is it because > you think all of the original patch needs to go? I felt that the patch > just overachieved a bit from what it initially set out to do (detect > unspecified return registers), and so I felt it was ok to send a > followup rather than redo it entirely. Pretty much both. The original diff was clearly wrong, and it is best to have the history reflect that clearly. But it will also make the review easier. To be honest, I think the conditional, after your modification, is too confusing. Didn't realize that the tests were part of the same commit though. So you probably can't simply use git revert. Perhaps that means we should commit testsuite changes seperately in the future.