From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30477 invoked by alias); 26 Nov 2013 13:55:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30455 invoked by uid 89); 26 Nov 2013 13:55:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.8 required=5.0 tests=AWL,BAYES_50,RDNS_NONE autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from Unknown (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 26 Nov 2013 13:55:36 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 9474E116483; Tue, 26 Nov 2013 08:56:03 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id E9ZyxRyEkSaq; Tue, 26 Nov 2013 08:56:03 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 3992C116449; Tue, 26 Nov 2013 08:56:03 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 84F45E0795; Tue, 26 Nov 2013 17:55:19 +0400 (RET) Date: Tue, 26 Nov 2013 14:37:00 -0000 From: Joel Brobecker To: Mark Kettenis Cc: tromey@redhat.com, gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] handle an unspecified return address column Message-ID: <20131126135519.GI3114@adacore.com> References: <1384375873-32160-1-git-send-email-tromey@redhat.com> <1384375873-32160-3-git-send-email-tromey@redhat.com> <20131126133446.GA28596@adacore.com> <201311261348.rAQDmBs1032481@glazunov.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201311261348.rAQDmBs1032481@glazunov.sibelius.xs4all.nl> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-11/txt/msg00811.txt.bz2 > > gdb/ChangeLog: > > > > PR backtrace/16155: > > * dwarf2-frame.c (dwarf2_frame_cache): Remove condition that > > sets cache->undefined_retaddr to 1 if there is no column in > > the frame info for the return register. > > > > Tested on x86_64-linux, no regression. It also fixes all regressions > > observed on arm-elf and ppc-elf. > > > > Can you tell me what you think? > > Please start with backing out the original change. I would gladly do so, but can you explain the rationale behind your request? Is it to facilitate review of this patch? Or is it because you think all of the original patch needs to go? I felt that the patch just overachieved a bit from what it initially set out to do (detect unspecified return registers), and so I felt it was ok to send a followup rather than redo it entirely. -- Joel