From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16461 invoked by alias); 15 Nov 2013 14:54:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16452 invoked by uid 89); 15 Nov 2013 14:54:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 Nov 2013 14:54:38 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAFEsQmL000947 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 15 Nov 2013 09:54:26 -0500 Received: from host2.jankratochvil.net (ovpn-116-37.ams2.redhat.com [10.36.116.37]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rAFEsL9L009784 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Fri, 15 Nov 2013 09:54:24 -0500 Date: Fri, 15 Nov 2013 15:27:00 -0000 From: Jan Kratochvil To: Samuel Bronson Cc: gdb-patches@sourceware.org, Tom Tromey , Doug Evans , Eli Zaretskii Subject: Re: [PATCH v4] Resurrect gdb-add-index as a contrib script Message-ID: <20131115145421.GA3096@host2.jankratochvil.net> References: <1383519137-26388-1-git-send-email-naesten@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00414.txt.bz2 On Sun, 03 Nov 2013 22:57:59 +0100, Samuel Bronson wrote: > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -32,6 +32,9 @@ > Before, the former would print "", and the latter > "*value not available*". > > +* New script contrib/gdb-add-index.sh for adding .gdb_index sections > + to binaries. > + > * Python scripting > > ** Frame filters and frame decorators have been added. Eli usually reviews the NEWS part. > diff --git a/gdb/contrib/gdb-add-index.sh b/gdb/contrib/gdb-add-index.sh > new file mode 100755 > index 0000000..145073a > --- /dev/null > +++ b/gdb/contrib/gdb-add-index.sh > @@ -0,0 +1,68 @@ > +#! /bin/sh > + > +# Add a .gdb_index section to a file. > + > +# Copyright (C) 2010, 2012-2013 Free Software Foundation, Inc. > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 3 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see . > + > +# This program assumes gdb and objcopy are in $PATH. > +# If not, or you want others, pass the following in the environment > +GDB=${GDB:=gdb} > +OBJCOPY=${OBJCOPY:=objcopy} > + > +myname="${0##*/}" > + > +if test $# != 1; then > + echo "usage: $myname FILE" 1>&2 > + exit 1 > +fi > + > +file="$1" > + > +if test ! -r "$file"; then > + echo "$myname: unable to access: $file" 1>&2 > + exit 1 > +fi > + > +dir="${file%/*}" > +test "$dir" = "$file" && dir="." > +index="${file}.gdb-index" You should test here $index does not exist; or just rm -f it. Such existing file may confuse this script. > + > +# Ensure intermediate index file is removed when we exit. > +trap "rm -f $index" 0 > + > +$GDB --batch -nx -iex 'set auto-load no' \ > + -ex "file $file" -ex "save gdb-index $dir" || { > + # Just in case. > + status=$? > + echo "$myname: gdb error generating index" 1>&2 You could say also $file here. For example during rpmbuild gdb-add-index is run but the script does not have 'set -x' so gdb-add-index's errors appear between other messages. > + exit $status > +} > + > +# In some situations gdb can exit without creating an index. This is > +# not an error. > +# E.g., if $file is stripped. This behaviour is akin to stripping an > +# already stripped binary, it's a no-op. > +status=0 > + > +if test -f "$index"; then > + $OBJCOPY --add-section .gdb_index="$index" \ > + --set-section-flags .gdb_index=readonly "$file" "$file" > + status=$? > +else > + echo "$myname: No index was created." 1>&2 You could say also $file here. > + echo "[Was there anything to index? Was there already an index?]" 1>&2 echo "$myname: [Was there anything to index? Was there already an index?]" 1>&2 > +fi > + > +exit $status > -- > 1.8.4.rc3 OK with these changes from me. Thanks, Jan