Re: [RFA] Fix DW_OP_GNU_regval_type with FP registers

Tom Tromey
2013-11-14T20:54:38Z

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> * dwarf2expr.h (struct dwarf_expr_context_funcs) <read_reg>:
Joel> Extend the documentation a bit.
Joel> <get_reg_value>: New field.
Joel> * dwarf2loc.c (dwarf_expr_get_reg_value)
Joel> (needs_frame_get_reg_value): New functions.
Joel> (dwarf_expr_ctx_funcs, needs_frame_ctx_funcs): Add "get_reg_value"
Joel> callback.
Joel> * dwarf2-frame.c (get_reg_value): New function.
Joel> (dwarf2_frame_ctx_funcs): Add "get_reg_value" callback.
Joel> * dwarf2expr.c (execute_stack_op) <DW_OP_GNU_regval_type>:
Joel> Use new callback to compute result_val.

Joel> gdb/testsuite/ChangeLog:

Joel> * O2_float_param: New testcase.

Joel> tested on x86_64-linux and ppc-linux.
Joel> OK to commit?

It looks good to me.

Tom