From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9949 invoked by alias); 15 Nov 2013 12:06:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9938 invoked by uid 89); 15 Nov 2013 12:06:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.3 required=5.0 tests=AWL,BAYES_20,RDNS_NONE,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from Unknown (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 15 Nov 2013 12:06:45 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id BF80611664F; Fri, 15 Nov 2013 07:07:09 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id aY4LhnMV9yGU; Fri, 15 Nov 2013 07:07:09 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 66BAC1165A6; Fri, 15 Nov 2013 07:07:09 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id AEC98E1292; Fri, 15 Nov 2013 16:06:35 +0400 (RET) Date: Fri, 15 Nov 2013 12:19:00 -0000 From: Joel Brobecker To: Tom Tromey , Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Fix DW_OP_GNU_regval_type with FP registers Message-ID: <20131115120635.GV3481@adacore.com> References: <1384434175-15561-1-git-send-email-brobecker@adacore.com> <877gcawvp9.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <877gcawvp9.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-11/txt/msg00409.txt.bz2 > >>>>> "Joel" == Joel Brobecker writes: > > Joel> * dwarf2expr.h (struct dwarf_expr_context_funcs) : > Joel> Extend the documentation a bit. > Joel> : New field. > Joel> * dwarf2loc.c (dwarf_expr_get_reg_value) > Joel> (needs_frame_get_reg_value): New functions. > Joel> (dwarf_expr_ctx_funcs, needs_frame_ctx_funcs): Add "get_reg_value" > Joel> callback. > Joel> * dwarf2-frame.c (get_reg_value): New function. > Joel> (dwarf2_frame_ctx_funcs): Add "get_reg_value" callback. > Joel> * dwarf2expr.c (execute_stack_op) : > Joel> Use new callback to compute result_val. > > Joel> gdb/testsuite/ChangeLog: > > Joel> * O2_float_param: New testcase. > > Joel> tested on x86_64-linux and ppc-linux. > Joel> OK to commit? Thanks both, Pedro and Tom, for reviewing the patch. I immediately starting thinking about Pedro's suggestion... > (Eliminating read_reg might be tricky, but I think it'd be nice > if it were be renamed to something that implies "address", like > read_addr_reg or some such.) ... and forgot to announce here that I pushed the patch this morning. Regarding Pedro's suggestion, what do we think of "read_addr_from_reg"? Still not perfect, as it hides a bit the fact that it only does a partial register read if the address size is smaller than the register size. But much better than "read_reg", I agree. -- Joel