From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20108 invoked by alias); 14 Nov 2013 09:48:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20086 invoked by uid 89); 14 Nov 2013 09:48:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00,RDNS_NONE autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from Unknown (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 14 Nov 2013 09:48:13 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 93346116518; Thu, 14 Nov 2013 04:48:37 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id V7S1Klc04-4o; Thu, 14 Nov 2013 04:48:37 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 366041164A9; Thu, 14 Nov 2013 04:48:37 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id D713CE0CD6; Thu, 14 Nov 2013 13:48:02 +0400 (RET) Date: Thu, 14 Nov 2013 09:52:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] use error, not internal_error, in dwarf2-frame.c Message-ID: <20131114094802.GN3481@adacore.com> References: <1384375392-32110-1-git-send-email-tromey@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1384375392-32110-1-git-send-email-tromey@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-11/txt/msg00364.txt.bz2 > I think that gdb should not call internal_error for bad DWARF. > Instead, it should simply throw an ordinary exception. FWIW, I agree with the reasoning. > 2013-11-13 Tom Tromey > > * dwarf2-frame.c (execute_cfa_program, dwarf2_compile_cfa_to_ax) > (dwarf2_frame_cache, dwarf2_frame_prev_register) > (encoding_for_size, read_encoded_value): Use error, not > internal_error. -- Joel