From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3420 invoked by alias); 13 Nov 2013 02:56:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3411 invoked by uid 89); 13 Nov 2013 02:56:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.0 required=5.0 tests=AWL,BAYES_05,RDNS_NONE,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from Unknown (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 13 Nov 2013 02:56:45 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 763B21166C0; Tue, 12 Nov 2013 21:57:09 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id GsUlNtsK4-8p; Tue, 12 Nov 2013 21:57:09 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 112C8116590; Tue, 12 Nov 2013 21:57:08 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 5CBD0E0735; Wed, 13 Nov 2013 06:56:34 +0400 (RET) Date: Wed, 13 Nov 2013 03:02:00 -0000 From: Joel Brobecker To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [RFC] Add ada-exception-catchpoints to -list-features command output. Message-ID: <20131113025634.GI3481@adacore.com> References: <1384076960-12339-1-git-send-email-brobecker@adacore.com> <831u2o41on.fsf@gnu.org> <20131112095416.GD3481@adacore.com> <83vbzx1tlc.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="0lnxQi9hkpPO77W3" Content-Disposition: inline In-Reply-To: <83vbzx1tlc.fsf@gnu.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-11/txt/msg00334.txt.bz2 --0lnxQi9hkpPO77W3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 691 > > Thanks for the review. As discussed with Tom, I've decided to > > merge the two entries into one. Attached is a patch that does that, > > together with a revised manual update. Can you tell me what you think? > > In particular, I am wondering whether the "all related to Ada > > exceptions" really brings anything in this context other than noise. > > Looks good to me, although I suggest a minor correction below. > > > +Indicates support for the following commands, all related to Ada > > +exceptions: ^^^^^^^^^^^ > > I suggest "all of them related" here. I made the correction you suggested, and pushed the attached patch. Thank you! -- Joel --0lnxQi9hkpPO77W3 Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-Replace-info-ada-exceptions-by-ada-exceptions-in-lis.patch" Content-length: 3603 >From 93973826c486a6b7b03eddb201e3ce994dd0fb5b Mon Sep 17 00:00:00 2001 From: Joel Brobecker Date: Tue, 12 Nov 2013 13:43:44 +0400 Subject: [PATCH] Replace "info-ada-exceptions" by "ada-exceptions" in -list-features Rather than having -list-features report support for the GDB/MI commands providing access to Ada exception catchpoints with one entry, and the GDB/MI command providing the list of Ada exceptions with a second entry, this patch merges it all within one single entry. This is OK, because all these commands were added within a short amount of time, and within the same release cycle; and it reduces a bit the size of the output. gdb/ChangeLog: * mi/mi-main.c (mi_cmd_list_features): Replace "info-ada-exceptions" entry with "ada-exceptions". gdb/doc/ChangeLog: * gdb.texinfo (GDB/MI Miscellaneous Commands): Delete the documentation of "info-ada-exceptions" in the output of the "-list-features" command. Add the documentation of the "ada-exception" entry instead. --- gdb/ChangeLog | 5 +++++ gdb/doc/ChangeLog | 8 ++++++++ gdb/doc/gdb.texinfo | 6 ++++-- gdb/mi/mi-main.c | 2 +- 4 files changed, 18 insertions(+), 3 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 279e3e2..6c20cce 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,10 @@ 2013-11-13 Joel Brobecker + * mi/mi-main.c (mi_cmd_list_features): Replace "info-ada-exceptions" + entry with "ada-exceptions". + +2013-11-13 Joel Brobecker + * symfile.c (reread_symbols): Move call to set_objfile_per_bfd after re-initialization of OBJFILE's obstack. diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog index 2b13843..968201e 100644 --- a/gdb/doc/ChangeLog +++ b/gdb/doc/ChangeLog @@ -1,5 +1,13 @@ +2013-11-13 Joel Brobecker + + * gdb.texinfo (GDB/MI Miscellaneous Commands): Delete + the documentation of "info-ada-exceptions" in the output + of the "-list-features" command. Add the documentation + of the "ada-exception" entry instead. + 2013-11-12 Joel Brobecker + * gdb.texinfo (GDB/MI Miscellaneous Commands): Fix the first word of a couple of sentences to start with a capital letter. diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index de419ea..84acd5c 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -35080,8 +35080,10 @@ Indicates that changes to breakpoints and breakpoints created via the CLI will be announced via async records. @item ada-task-info Indicates support for the @code{-ada-task-info} command. -@item info-ada-exceptions -Indicates support for the @code{-info-ada-exceptions} command. +@item ada-exceptions +Indicates support for the following commands, all of them related to Ada +exceptions: @code{-info-ada-exceptions}, @code{-catch-assert} and +@code{-catch-exception}. @end table @subheading The @code{-list-target-features} Command diff --git a/gdb/mi/mi-main.c b/gdb/mi/mi-main.c index bf0fce3..c3f7221 100644 --- a/gdb/mi/mi-main.c +++ b/gdb/mi/mi-main.c @@ -1815,7 +1815,7 @@ mi_cmd_list_features (char *command, char **argv, int argc) ui_out_field_string (uiout, NULL, "data-read-memory-bytes"); ui_out_field_string (uiout, NULL, "breakpoint-notifications"); ui_out_field_string (uiout, NULL, "ada-task-info"); - ui_out_field_string (uiout, NULL, "info-ada-exceptions"); + ui_out_field_string (uiout, NULL, "ada-exceptions"); #if HAVE_PYTHON if (gdb_python_initialized) -- 1.8.1.2 --0lnxQi9hkpPO77W3--