From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30461 invoked by alias); 12 Nov 2013 18:46:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30399 invoked by uid 89); 12 Nov 2013 18:46:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,SPF_HELO_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Nov 2013 18:46:11 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rACIk0Yd018720 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 12 Nov 2013 13:46:01 -0500 Received: from host2.jankratochvil.net (ovpn-116-37.ams2.redhat.com [10.36.116.37]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rACIjucJ012708 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Tue, 12 Nov 2013 13:45:58 -0500 Date: Tue, 12 Nov 2013 19:58:00 -0000 From: Jan Kratochvil To: Doug Evans Cc: Tom Tromey , gdb-patches , Pedro Alves , Stan Shebs Subject: Re: [PATCH] Fix Gold/strip discrepancies for PR 11786 Message-ID: <20131112184556.GA20259@host2.jankratochvil.net> References: <20131105172219.GA21529@host2.jankratochvil.net> <20131105180547.GA24004@host2.jankratochvil.net> <20131106212434.GA4193@host2.jankratochvil.net> <20131107190059.GA24230@host2.jankratochvil.net> <21117.8566.225807.905608@ruffy.mtv.corp.google.com> <20131108175033.GA11849@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00325.txt.bz2 On Tue, 12 Nov 2013 19:33:33 +0100, Doug Evans wrote: > https://sourceware.org/gdb/wiki/Internals%20GDB-Testsuite-Coding-Standards > > Feel free to tweak or add whatever community rules there are. > I'll add more as it occurs to me. FYI I find In C code, don't use K&R function definitions redundant against the part above The best guidance one can give is that unless a test requires a particular style (which is rare) you can't go wrong following the GDB coding standards. but it is OK even as a redundant text. Jan