From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-106906-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15004 invoked by alias); 5 Nov 2013 13:36:49 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 14992 invoked by uid 89); 5 Nov 2013 13:36:48 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2
X-HELO: mx1.redhat.com
Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Nov 2013 13:36:47 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rA5Dadr0006520	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Tue, 5 Nov 2013 08:36:39 -0500
Received: from host2.jankratochvil.net (ovpn-116-29.ams2.redhat.com [10.36.116.29])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rA5DaZhd000428	(version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO);	Tue, 5 Nov 2013 08:36:38 -0500
Date: Tue, 05 Nov 2013 17:04:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>,        Cary Coutant <ccoutant@google.com>
Subject: Re: [PATCH] Fix Gold/strip discrepancies for PR 11786
Message-ID: <20131105133635.GA31641@host2.jankratochvil.net>
References: <yjt24n85x78h.fsf@ruffy.mtv.corp.google.com> <20131031154957.GA11260@host2.jankratochvil.net> <CADPb22QKBpYpmmZzeKJy7JWukpfkTQcYZDm+KeEkr6K_92LJ2A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CADPb22QKBpYpmmZzeKJy7JWukpfkTQcYZDm+KeEkr6K_92LJ2A@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-IsSubscribed: yes
X-SW-Source: 2013-11/txt/msg00073.txt.bz2

On Mon, 04 Nov 2013 23:21:33 +0100, Doug Evans wrote:
> On Thu, Oct 31, 2013 at 8:49 AM, Jan Kratochvil
> > On Sat, 26 Oct 2013 01:26:22 +0200, Doug Evans wrote:
> >> --- a/gdb/solib-svr4.c
> >> +++ b/gdb/solib-svr4.c
> >> @@ -2608,6 +2608,22 @@ svr4_exec_displacement (CORE_ADDR *displacementp)
> >>                 if (memcmp (phdrp, phdr2p, sizeof (*phdrp)) == 0)
> >>                   continue;
> >>
> >> +               /* Gold and strip differ on the flags and alignment of
> >> +                  PT_GNU_RELRO.  See PR 11786.  */
> >> +               if (phdr2[i].p_type == PT_GNU_RELRO)
> >> +               {
> >> +                 Elf32_External_Phdr tmp_phdr = *phdrp;
> >> +                 Elf32_External_Phdr tmp_phdr2 = *phdr2p;
> >
> > One can modify directly *phdrp and *phdr2p, when we decide to ignore the
> > PT_GNU_RELRO differences there is no other use for that data.
> 
> I like the locality, and not imposing the side effect outside the
> scope of the task at hand (PT_GNU_RELRO).

OK, why not.


Jan