From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31846 invoked by alias); 26 Oct 2013 04:09:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31828 invoked by uid 89); 26 Oct 2013 04:09:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Sat, 26 Oct 2013 04:09:16 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 139791161CD; Sat, 26 Oct 2013 00:09:40 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id G2WDbJXBiKZc; Sat, 26 Oct 2013 00:09:40 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id AEE6B1165F6; Sat, 26 Oct 2013 00:09:39 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 15789E069D; Sat, 26 Oct 2013 08:09:11 +0400 (RET) Date: Sat, 26 Oct 2013 04:09:00 -0000 From: Joel Brobecker To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Remove varobj_language_string, languages and varobj_languages Message-ID: <20131026040911.GD4769@adacore.com> References: <1382057576-19148-1-git-send-email-yao@codesourcery.com> <1382057576-19148-2-git-send-email-yao@codesourcery.com> <20131025041525.GC4769@adacore.com> <526A7407.5090301@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <526A7407.5090301@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-10/txt/msg00839.txt.bz2 > >I think this can do for now because it is good enough, but I would > >definitely prefer we avoid this type transformation. Instead, > >I'd rather we added a new field in struct language_defn that > >provides the "natural" name. > > > > I am OK to add a new field "la_varobj_name" in struct language_defn, > but seems information is duplicated a little, we have both "c++" and > "C++" in one language_defn. It would not be a "varobj" name, but a "natural" name, that is the name one would use when naming the language; eg: "Fortran 90" instead of "f90". One possible analogy in our code base is the shortname/longname distinction in struct target_ops. -- Joel