From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19188 invoked by alias); 24 Oct 2013 17:57:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19176 invoked by uid 89); 24 Oct 2013 17:57:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 24 Oct 2013 17:57:18 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 478301166F0; Thu, 24 Oct 2013 13:57:42 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id LBRXA+WynO3x; Thu, 24 Oct 2013 13:57:42 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id BB57A1166D6; Thu, 24 Oct 2013 13:57:41 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id D5856E10A4; Thu, 24 Oct 2013 21:57:12 +0400 (RET) Date: Thu, 24 Oct 2013 17:57:00 -0000 From: Joel Brobecker To: Mark Kettenis Cc: ooprala@redhat.com, gdb-patches@sourceware.org, tromey@redhat.com Subject: Re: [PATCH 01/18] poison "class" Message-ID: <20131024175712.GA4769@adacore.com> References: <1381339053-14519-1-git-send-email-ooprala@redhat.com> <1381339053-14519-2-git-send-email-ooprala@redhat.com> <201310201912.r9KJCuKB015989@glazunov.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201310201912.r9KJCuKB015989@glazunov.sibelius.xs4all.nl> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-10/txt/msg00764.txt.bz2 > I strongly object to the deliberate misspelling of "class" that this > diff introduces. Unless we're actually make the decision to rewrite > GDB in C++ (to which I strongly object in the first place) I don't > think this (and other) uglification diffs should go in. I usually relate to that, but "klass" is quite commonly used, in C, C++, and other languages, so I don't think this does much damage to our code base in this particular instance. -- Joel