From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4093 invoked by alias); 18 Oct 2013 17:20:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4081 invoked by uid 89); 18 Oct 2013 17:20:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 Oct 2013 17:20:41 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9IHKacN003384 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 18 Oct 2013 13:20:36 -0400 Received: from host2.jankratochvil.net (ovpn-116-33.ams2.redhat.com [10.36.116.33]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r9IHKWEl015669 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Fri, 18 Oct 2013 13:20:35 -0400 Date: Fri, 18 Oct 2013 17:20:00 -0000 From: Jan Kratochvil To: Pierre Muller Cc: Keith Seitz , "gdb-patches@sourceware.org ml" , Sergio Durigan Junior , Tom Tromey Subject: Re: Regression for gdb.pascal/* [Re: [RFA 4/4] Constify parse_linesepc] Message-ID: <20131018172032.GA12122@host2.jankratochvil.net> References: <5249C987.50809@redhat.com> <87d2no4uim.fsf@fleche.redhat.com> <524BA344.2070802@redhat.com> <20131016095743.GA17072@host2.jankratochvil.net> <52602A08.4020705@redhat.com> <87ob6ntyc4.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ob6ntyc4.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00578.txt.bz2 On Thu, 17 Oct 2013 22:51:55 +0200, Tom Tromey wrote: > >>>>> "Keith" == Keith Seitz writes: > > Keith> There are two little sections of code, though, which violate > Keith> const-ness of the input, and I've removed those, since they don't > Keith> seem necessary. [This is the two loops that deal with changing > Keith> the case of `tokstart' -- which can easily be removed because we > Keith> already have a temporary buffer that is used for this.] > > I think it's somewhat wrong to do this stuff in the parser anyhow. > Ideally the symbol table ought to know that pascal is case-insensitive. > I think we faced this with Fortran as well. Case insensitive symbols should be supported (originally written for Fortran) since: commit 5b7743a275e4610fe6ea57f0c61e317490ee6854 Date: Wed Apr 27 20:03:03 2011 +0000 Case insensitive lookups implementation. (+about one fallout later) While f_language_defn has case_sensitive_off I see that pascal_language_defn has case_sensitive_on. At https://en.wikipedia.org/wiki/Pascal_%28programming_language%29#Hello_world I read Letter case is ignored in Pascal source. so I think pascal_language_defn really should use case_sensitive_off. Jan