From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15606 invoked by alias); 13 Oct 2013 17:25:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15596 invoked by uid 89); 13 Oct 2013 17:25:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 13 Oct 2013 17:25:32 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9DHPVAf000933 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 13 Oct 2013 13:25:31 -0400 Received: from host2.jankratochvil.net (ovpn-116-94.ams2.redhat.com [10.36.116.94]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r9DHPRVX028867 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Sun, 13 Oct 2013 13:25:30 -0400 Date: Sun, 13 Oct 2013 17:25:00 -0000 From: Jan Kratochvil To: Ondrej Oprala Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH 14/18] poison "using" Message-ID: <20131013172527.GJ12719@host2.jankratochvil.net> References: <1381339053-14519-1-git-send-email-ooprala@redhat.com> <1381339053-14519-15-git-send-email-ooprala@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1381339053-14519-15-git-send-email-ooprala@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00416.txt.bz2 On Wed, 09 Oct 2013 19:17:29 +0200, Ondrej Oprala wrote: [...] > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -17,6 +17,11 @@ > > 2013-10-09 Tom Tromey > > + * block.c (using_direct) : Renamed from using. > + * block.h (using_direct) : Likewise. ChangeLog is not correct, described elsewhere. > + > +2013-10-09 Tom Tromey > + > * ada-lang.c (type_name) : Renamed from typename. > * break-catch-throw.c (type_name) : Likewise. > * cp-valprint.c (type_name) : Likewise. > diff --git a/gdb/block.c b/gdb/block.c > index 643e144..7d1700e 100644 > --- a/gdb/block.c > +++ b/gdb/block.c [...] > -/* Set BLOCK's using member to USING; if needed, allocate memory via > - OBSTACK. (It won't make a copy of USING, however, so that already > +/* Set BLOCK's using member to USING_DIRECT; if needed, allocate memory via > + OBSTACK. (It won't make a copy of USING_DIRECT, however, so that already > has to be allocated correctly.) */ > > void > block_set_using (struct block *block, > - struct using_direct *using, > + struct using_direct *using_direct, > struct obstack *obstack) > { [...] > --- a/gdb/block.h > +++ b/gdb/block.h > @@ -170,7 +170,7 @@ extern void block_set_scope (struct block *block, const char *scope, > extern struct using_direct *block_using (const struct block *block); > > extern void block_set_using (struct block *block, > - struct using_direct *using, > + struct using_direct *using_dir, Function defintion uses name 'using_direct' so it should be in sync here. > struct obstack *obstack); > > extern const struct block *block_static_block (const struct block *block); > -- > 1.8.3.1 Thanks, Jan