From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5887 invoked by alias); 13 Oct 2013 17:16:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5875 invoked by uid 89); 13 Oct 2013 17:16:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 13 Oct 2013 17:16:14 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9DHGCnR003977 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 13 Oct 2013 13:16:12 -0400 Received: from host2.jankratochvil.net (ovpn-116-94.ams2.redhat.com [10.36.116.94]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r9DHG9qa017831 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Sun, 13 Oct 2013 13:16:11 -0400 Date: Sun, 13 Oct 2013 17:16:00 -0000 From: Jan Kratochvil To: Ondrej Oprala Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH 08/18] poison "mutable" Message-ID: <20131013171608.GA32516@host2.jankratochvil.net> References: <1381339053-14519-1-git-send-email-ooprala@redhat.com> <1381339053-14519-9-git-send-email-ooprala@redhat.com> <20131013170025.GD12719@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131013170025.GD12719@host2.jankratochvil.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00410.txt.bz2 On Sun, 13 Oct 2013 19:00:25 +0200, Jan Kratochvil wrote: > On Wed, 09 Oct 2013 19:17:23 +0200, Ondrej Oprala wrote: > > --- a/gdb/ChangeLog > > +++ b/gdb/ChangeLog > > @@ -17,6 +17,10 @@ > > > > 2013-10-09 Tom Tromey > > > > + * addrmap.c (mutable_map) : Rename from mutable. > > Use tab + parenthesis content is incorrect, as described elsewhere. > And s/ : /: /. > > > > + > > +2013-10-09 Tom Tromey > > + > > * mi/mi-cmd-var.c (is_explicit) : Rename from explicit. > > * varobj.c (is_explicit) : Likewise. > > * varobj.h (is_explicit) : Likewise. > > diff --git a/gdb/addrmap.c b/gdb/addrmap.c > > index 348fd43..ccd125c 100644 > > --- a/gdb/addrmap.c > > +++ b/gdb/addrmap.c > > @@ -429,16 +429,16 @@ splay_foreach_copy (splay_tree_node n, void *closure) > > static struct addrmap * > > addrmap_mutable_create_fixed (struct addrmap *self, struct obstack *obstack) > > { > > - struct addrmap_mutable *mutable = (struct addrmap_mutable *) self; > > + struct addrmap_mutable *mutable_map = (struct addrmap_mutable *) self; > > struct addrmap_fixed *fixed; > > size_t num_transitions; > > > > /* Count the number of transitions in the tree. */ > > num_transitions = 0; > > - splay_tree_foreach (mutable->tree, splay_foreach_count, &num_transitions); > > + splay_tree_foreach (mutable_map->tree, splay_foreach_count, &num_transitions); > > Line exceeds 80 columns. It does not, my mistake. > > > > /* Include an extra entry for the transition at zero (which fixed > > - maps have, but mutable maps do not.) */ > > + maps have, but mutable_map maps do not.) */ > > num_transitions++; > > > > fixed = obstack_alloc (obstack, > > @@ -452,7 +452,7 @@ addrmap_mutable_create_fixed (struct addrmap *self, struct obstack *obstack) > > > > /* Copy all entries from the splay tree to the array, in order > > of increasing address. */ > > - splay_tree_foreach (mutable->tree, splay_foreach_copy, fixed); > > + splay_tree_foreach (mutable_map->tree, splay_foreach_copy, fixed); > > > > /* We should have filled the array. */ > > gdb_assert (fixed->num_transitions == num_transitions); > > @@ -496,12 +496,12 @@ static int > > addrmap_mutable_foreach (struct addrmap *self, addrmap_foreach_fn fn, > > void *data) > > { > > - struct addrmap_mutable *mutable = (struct addrmap_mutable *) self; > > + struct addrmap_mutable *mutable_map = (struct addrmap_mutable *) self; > > struct mutable_foreach_data foreach_data; > > > > foreach_data.fn = fn; > > foreach_data.data = data; > > - return splay_tree_foreach (mutable->tree, addrmap_mutable_foreach_worker, > > + return splay_tree_foreach (mutable_map->tree, addrmap_mutable_foreach_worker, > > Line exceeds 80 columns. It does not, my mistake. > > &foreach_data); > > } > > > > -- > > 1.8.3.1 Therefore the patch itself is OK. > > > Thanks, > Jan