Re: [PATCH 04/18] poison "public"

Jan Kratochvil
2013-10-13T16:39:34Z

On Wed, 09 Oct 2013 19:17:19 +0200, Ondrej Oprala wrote:
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -17,6 +17,10 @@
>
> 2013-10-09 Tom Tromey <tromey@redhat.com>
>
> + * gdbtypes.c (is_public): Renamed from public.

It should use tab for indentation. But according to the "addrmap.c" text
below your on-disk file is probably right but it just got corrupted by mail.
Therefore mail it differently, please.

You should put function name in parentheses. Therefore:
* gdbtypes.c (distance_to_ancestor): Rename parameter public to
is_public.

But I disagree with "is_public", it does not have such meaning in this
function. One could use for example "public_only", "require_public" or
"traverse_public" here. Function-independent could be "public_flag".

> +
> +2013-10-09 Tom Tromey <tromey@redhat.com>
> +
> * addrmap.c (self) : Renamed from this.
> * cp-namespace.c (this_sym) : Likewise.
> * frame.c (self) : Likewise.
[...]

Thanks,
Jan