From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23268 invoked by alias); 13 Oct 2013 16:47:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23259 invoked by uid 89); 13 Oct 2013 16:47:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 13 Oct 2013 16:47:00 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9DGkwGe028564 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 13 Oct 2013 12:46:58 -0400 Received: from host2.jankratochvil.net (ovpn-116-94.ams2.redhat.com [10.36.116.94]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r9DGktiv016470 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Sun, 13 Oct 2013 12:46:57 -0400 Date: Sun, 13 Oct 2013 16:47:00 -0000 From: Jan Kratochvil To: Ondrej Oprala Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH 06/18] poison "delete" Message-ID: <20131013164654.GB12719@host2.jankratochvil.net> References: <1381339053-14519-1-git-send-email-ooprala@redhat.com> <1381339053-14519-7-git-send-email-ooprala@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1381339053-14519-7-git-send-email-ooprala@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00407.txt.bz2 On Wed, 09 Oct 2013 19:17:21 +0200, Ondrej Oprala wrote: [...] Missing ChangeLog here. > diff --git a/gdb/ui-file.h b/gdb/ui-file.h > index ba0a908..8072fbd 100644 > --- a/gdb/ui-file.h > +++ b/gdb/ui-file.h > @@ -77,7 +77,7 @@ extern void set_ui_file_put (struct ui_file *stream, ui_file_put_ftype *put); > > typedef void (ui_file_delete_ftype) (struct ui_file * stream); > extern void set_ui_file_data (struct ui_file *stream, void *data, > - ui_file_delete_ftype *delete); > + ui_file_delete_ftype *deleter); The function definition already uses: ui-file.c: set_ui_file_data (struct ui_file *file, void *data, ui_file_delete_ftype *delete_ptr) Therefore I find better to get them in sync and use "delete_ptr" even in the header file declaration. > > typedef int (ui_file_fseek_ftype) (struct ui_file *stream, long offset, > int whence); > -- > 1.8.3.1 Thanks, Jan