From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8997 invoked by alias); 11 Oct 2013 13:57:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8984 invoked by uid 89); 11 Oct 2013 13:57:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 11 Oct 2013 13:57:20 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 55A3F116790; Fri, 11 Oct 2013 09:57:40 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id r58nlo0OKNVv; Fri, 11 Oct 2013 09:57:40 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id E95B11166E9; Fri, 11 Oct 2013 09:57:39 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 42D7AE0759; Fri, 11 Oct 2013 17:57:18 +0400 (RET) Date: Fri, 11 Oct 2013 13:57:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [commit/Ada] psymbol search failure due to comparison function discrepancy Message-ID: <20131011135718.GU3092@adacore.com> References: <1381231039-4090-1-git-send-email-brobecker@adacore.com> <87r4bs4zn0.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87r4bs4zn0.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-10/txt/msg00384.txt.bz2 > Is it possible to construct a synthetic test case using the DWARF assembler? > > I ask because I think that, while the patch is fine, having two > functions which must remain in sync semantically, where one such > function is only used by Ada and has no test case for some branches, is > definitely going to cause future regressions. I agree. Let me see what I can do... In the long term, I'd really like the psymtab to have the language, so we can simply use the same routine for both sorting and searching. ISTR other cases where I really wished I had access to the language from the psymtab. -- Joel