From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 647 invoked by alias); 10 Oct 2013 19:15:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 622 invoked by uid 89); 10 Oct 2013 19:15:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_STOCKTIP,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Oct 2013 19:15:07 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9AJF2Pa025225 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 10 Oct 2013 15:15:05 -0400 Received: from host2.jankratochvil.net (ovpn-116-51.ams2.redhat.com [10.36.116.51]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r9AJEwfY002753 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Thu, 10 Oct 2013 15:15:01 -0400 Date: Thu, 10 Oct 2013 19:15:00 -0000 From: Jan Kratochvil To: Ondrej Oprala Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH 02/18] poison "new" Message-ID: <20131010191458.GA14000@host2.jankratochvil.net> References: <1381339053-14519-1-git-send-email-ooprala@redhat.com> <1381339053-14519-3-git-send-email-ooprala@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1381339053-14519-3-git-send-email-ooprala@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00361.txt.bz2 On Wed, 09 Oct 2013 19:17:17 +0200, Ondrej Oprala wrote: > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -22,6 +22,43 @@ > > 2013-10-09 Tom Tromey > > + * bcache.c (new_bstr) : Renamed from new. > + * buildsym.c(new_ctx) : Likewise. > + * cleanups.c(new_cleanup) : Likewise. Besides Pedro's comment on formatting of the ChangeLog entry do not post ChangeLog entry already modified in the file. Post it only as a preceding text (commit message). You can see here the entry is wrongly placed, new entry should be always at the top of the file. Besides that it always causes patch or merge conflicts as the top of ChangeLog files is continually changing. [...] > --- a/gdb/dbxread.c > +++ b/gdb/dbxread.c [...] > @@ -2799,16 +2799,17 @@ process_one_symbol (int type, int desc, CORE_ADDR valu, char *name, > } > > within_function = 0; > - new = pop_context (); > + new_ctx = pop_context (); > > /* Make a block for the local symbols within. */ > - block = finish_block (new->name, &local_symbols, new->old_blocks, > - new->start_addr, new->start_addr + valu, > + block = finish_block (new_ctx->name, &local_symbols, > + new_ctx->old_blocks, > + new_ctx->start_addr, new_ctx->start_addr + valu, > objfile); > > /* For C++, set the block's scope. */ > - if (SYMBOL_LANGUAGE (new->name) == language_cplus) > - cp_set_block_scope (new->name, block, &objfile->objfile_obstack); > + if (SYMBOL_LANGUAGE (new_ctx->name) == language_cplus) > + cp_set_block_scope (new_ctx->name, block, &objfile->objfile_obstack); Line exceeds 80 columns. > > /* May be switching to an assembler file which may not be using > block relative stabs, so reset the offset. */ [...] > --- a/gdb/dwarf2read.c > +++ b/gdb/dwarf2read.c [...] > @@ -11030,12 +11030,12 @@ read_lexical_block_scope (struct die_info *die, struct dwarf2_cu *cu) > child_die = sibling_die (child_die); > } > } > - new = pop_context (); > + new_ctx = pop_context (); > > if (local_symbols != NULL || using_directives != NULL) > { > struct block *block > - = finish_block (0, &local_symbols, new->old_blocks, new->start_addr, > + = finish_block (0, &local_symbols, new_ctx->old_blocks, new_ctx->start_addr, Line exceeds 80 columns. > highpc, objfile); > > /* Note that recording ranges after traversing children, as we [...] > --- a/gdb/stabsread.c > +++ b/gdb/stabsread.c [...] > @@ -3184,7 +3184,7 @@ read_baseclasses (struct field_info *fip, char **pp, struct type *type, > corresponding to this baseclass. Always zero in the absence of > multiple inheritance. */ > > - SET_FIELD_BITPOS (new->field, read_huge_number (pp, ',', &nbits, 0)); > + SET_FIELD_BITPOS (new_fields->field, read_huge_number (pp, ',', &nbits, 0)); Line exceeds 80 columns. > if (nbits != 0) > return 0; > } Otherwise the patch is fine with me. Please repost it to recheck the proper GNU Coding Standards formatting of the long lines and the ChangeLog entry. Ondrej is covered by the Red Hat copyright assignment. I guess you do not have read/write access to the repository so I can do the check-in of some your first patches. Thanks, Jan