From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 990 invoked by alias); 9 Oct 2013 18:37:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 980 invoked by uid 89); 9 Oct 2013 18:37:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Oct 2013 18:37:35 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r99IbWlE018789 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 9 Oct 2013 14:37:33 -0400 Received: from host2.jankratochvil.net (ovpn-116-51.ams2.redhat.com [10.36.116.51]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r99IbSEc023149 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Wed, 9 Oct 2013 14:37:31 -0400 Date: Wed, 09 Oct 2013 18:37:00 -0000 From: Jan Kratochvil To: Eli Zaretskii Cc: tromey@redhat.com, ktietz@redhat.com, gdb-patches@sourceware.org Subject: Re: [patch] Minor O_CLOEXEC optimization, "regression" fix Message-ID: <20131009183728.GA22837@host2.jankratochvil.net> References: <20131008183214.GB27355@host2.jankratochvil.net> <87li23fsym.fsf@fleche.redhat.com> <20131009131016.GA1603@host2.jankratochvil.net> <83hacqqsx7.fsf@gnu.org> <87ob6ybcdc.fsf@fleche.redhat.com> <83bo2yqrop.fsf@gnu.org> <20131009174124.GA20135@host2.jankratochvil.net> <837gdmqqbv.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <837gdmqqbv.fsf@gnu.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00315.txt.bz2 On Wed, 09 Oct 2013 19:58:12 +0200, Eli Zaretskii wrote: > Then why did you ask this upthread: > > > May one rely on MS-Windows fopen("","re") will fail with EINVAL if it fails > > because of the "e" flag, Kai? It is in GDB function gdb_fopen_cloexec. > > ? That's what confused me. Sorry if I missed something. I did not realize / expect O_CLOEXEC is 0 on MS-Windows. Also MS-Windows has many build platforms like MinGW, Cygwin, ActiveState(?), 32 vs. 64 bit, native vs. cross, there exist various sets of include files either original or stolen by dirty room / clean room approaches, so when we talk about "MS-Windows" here do not believe we cover all the possible ways how to build MS-Windows hosted GDB. Also I do not believe that every platform not supporting "e" has to return EINVAL for it, some platform could IMO return a different error code, relying on EINVAL for "e" is IMO not cross-platform compatible enough. But whenever I try to build GDB on a non-Linux platform it fails for me anyway so I do not much believe in the claimed and attempted wide platform compatibility of GDB. Therefore I found it fine to make the code simpler and more optimal on GNU/Linux when there is an agreement from other maintainer(s). Regards, Jan