From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22230 invoked by alias); 8 Oct 2013 04:59:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22218 invoked by uid 89); 8 Oct 2013 04:59:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 08 Oct 2013 04:59:06 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 6069B1164D1; Tue, 8 Oct 2013 00:59:25 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id JW4RdTYpjKww; Tue, 8 Oct 2013 00:59:25 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id EB81C1164D5; Tue, 8 Oct 2013 00:59:24 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 12E2BE0CCA; Tue, 8 Oct 2013 08:59:01 +0400 (RET) Date: Tue, 08 Oct 2013 04:59:00 -0000 From: Joel Brobecker To: Doug Evans Cc: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH 5/7] New lang-varobj.h Message-ID: <20131008045901.GE3092@adacore.com> References: <1379512482-31773-1-git-send-email-yao@codesourcery.com> <1379512482-31773-6-git-send-email-yao@codesourcery.com> <21068.21875.734416.904684@ruffy.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21068.21875.734416.904684@ruffy.mtv.corp.google.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-10/txt/msg00206.txt.bz2 > > 2013-09-18 Yao Qi > > > > * Makefile.in (HFILES_NO_SRCDIR): Add lang-varobj.h. > > * lang-varobj.h: New. > > * varobj.c: Include "lang-varobj.h". > > (struct varobj_root): : Update its type. > > (struct language_specific): Move it to lang-varobj.h. > > Hi. > > How about move lang-varobj.h into varobj.h? Not very important in the grand scheme of things, but I tend to agree with the suggestion. If we had a lang-varobj.c, things might be different. But for a simple definition of the language-specific ops directly related to varobj, I'd keep things simple, inside varobj.h. -- Joel